membarrier(2): implement the MEMBARRIER_CMD_GET_REGISTRATIONS command
ClosedPublic
Actions

Authored by kib on Sat, Apr 18, 6:48 PM.

Details

Reviewers

markj
rbranco_suse.com

Commits

rG324b3c2892a5: membarrier.2: document MEMBARRIER_CMD_GET_REGISTRATIONS
rGaaa10396a997: membarrier(2): implement the MEMBARRIER_CMD_GET_REGISTRATIONS command
rG950fd59955e1: membarrier(2): use atomic for lockless read of curproc->p_flag2

Summary

Also:

membarrier(2): use atomic for lockless read of curproc->p_flag2

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Sat, Apr 18, 6:48 PM

Herald added subscribers: ziaee, olce, imp. · View Herald TranscriptSat, Apr 18, 6:48 PM

kib requested review of this revision.Sat, Apr 18, 6:48 PM

I succesfully tested the current patch with my suggestions along with https://github.com/freebsd/freebsd-src/pull/2147

sys/kern/kern_membarrier.c
124
230	Need to declare `int res = 0`
234
236
sys/sys/membarrier.h
52	This value collides with MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ below.

Branko' feedback.

rbranco_suse.com accepted this revision.Sat, Apr 18, 7:56 PM

This revision is now accepted and ready to land.Sat, Apr 18, 7:56 PM

In D56507#1293342, @rbranco_suse.com wrote:

I succesfully tested the current patch with my suggestions along with https://github.com/freebsd/freebsd-src/pull/2147

Is there any reason not to turn your test program into something we can run as part of the test suite?

Closed by commit rG950fd59955e1: membarrier(2): use atomic for lockless read of curproc->p_flag2 (authored by kib). · Explain WhyMon, Apr 20, 5:43 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG950fd59955e1: membarrier(2): use atomic for lockless read of curproc->p_flag2.

kib added a commit: rGaaa10396a997: membarrier(2): implement the MEMBARRIER_CMD_GET_REGISTRATIONS command.

kib added a commit: rG324b3c2892a5: membarrier.2: document MEMBARRIER_CMD_GET_REGISTRATIONS.

In D56507#1293791, @markj wrote:

In D56507#1293342, @rbranco_suse.com wrote:

I succesfully tested the current patch with my suggestions along with https://github.com/freebsd/freebsd-src/pull/2147

Is there any reason not to turn your test program into something we can run as part of the test suite?