Page MenuHomeFreeBSD
Differential D56507

membarrier(2): implement the MEMBARRIER_CMD_GET_REGISTRATIONS command
ClosedPublic
Actions

Authored by kib on Apr 18 2026, 6:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 17, 6:24 AM
Unknown Object (File)
Sun, May 17, 12:02 AM
Unknown Object (File)
Sat, May 16, 10:30 PM
Unknown Object (File)
Sat, May 16, 8:27 PM
Unknown Object (File)
Thu, May 14, 9:31 AM
Unknown Object (File)
Wed, May 13, 12:19 AM
Unknown Object (File)
Mon, May 11, 3:00 AM
Unknown Object (File)
Mon, May 11, 2:12 AM
View All 31 Files
Subscribers
imp
olce
rbranco_suse.com
ziaee

Details

Reviewers
markj
rbranco_suse.com
Commits
rG324b3c2892a5: membarrier.2: document MEMBARRIER_CMD_GET_REGISTRATIONS
rGaaa10396a997: membarrier(2): implement the MEMBARRIER_CMD_GET_REGISTRATIONS command
rG950fd59955e1: membarrier(2): use atomic for lockless read of curproc->p_flag2
Summary

Also:

membarrier(2): use atomic for lockless read of curproc->p_flag2

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Apr 18 2026, 6:48 PM
Herald added subscribers: ziaee, olce, imp. · View Herald TranscriptApr 18 2026, 6:48 PM
kib requested review of this revision.Apr 18 2026, 6:48 PM
rbranco_suse.com added a subscriber: rbranco_suse.com.Apr 18 2026, 7:24 PM

I succesfully tested the current patch with my suggestions along with https://github.com/freebsd/freebsd-src/pull/2147

sys/kern/kern_membarrier.c
123
229

Need to declare int res = 0

233
235
sys/sys/membarrier.h
52 ↗(On Diff #175845)

This value collides with MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ below.

kib updated this revision to Diff 175850.Apr 18 2026, 7:39 PM
kib marked 5 inline comments as done.
kib added a reviewer: markj.

Branko' feedback.

rbranco_suse.com accepted this revision.Apr 18 2026, 7:56 PM
This revision is now accepted and ready to land.Apr 18 2026, 7:56 PM
markj accepted this revision.Apr 20 2026, 3:31 PM
In D56507#1293342, @rbranco_suse.com wrote:

I succesfully tested the current patch with my suggestions along with https://github.com/freebsd/freebsd-src/pull/2147

Is there any reason not to turn your test program into something we can run as part of the test suite?

Closed by commit rG950fd59955e1: membarrier(2): use atomic for lockless read of curproc->p_flag2 (authored by kib). · Explain WhyApr 20 2026, 5:43 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG950fd59955e1: membarrier(2): use atomic for lockless read of curproc->p_flag2.
kib added a commit: rGaaa10396a997: membarrier(2): implement the MEMBARRIER_CMD_GET_REGISTRATIONS command.
kib added a commit: rG324b3c2892a5: membarrier.2: document MEMBARRIER_CMD_GET_REGISTRATIONS.
rbranco_suse.com added a comment.Apr 20 2026, 5:56 PM
In D56507#1293791, @markj wrote:
In D56507#1293342, @rbranco_suse.com wrote:

I succesfully tested the current patch with my suggestions along with https://github.com/freebsd/freebsd-src/pull/2147

Is there any reason not to turn your test program into something we can run as part of the test suite?

The test program was generated with the help from Claude Sonnet 4.6. I'd rather write my own test if it were to be included in FreeBSD.

Revision Contents
Changeset List

PathSize
sys/
kern/
13 lines

Diff 175930

View Options

sys/kern/kern_membarrier.c

Loading...