Page MenuHomeFreeBSD
Differential D56507

membarrier(2): implement the MEMBARRIER_CMD_GET_REGISTRATIONS command
AcceptedPublic
Actions

Authored by kib on Sat, Apr 18, 6:48 PM.

Details

Reviewers
markj
rbranco_suse.com
Summary

Also:

membarrier(2): use atomic for lockless read of curproc->p_flag2

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib created this revision.Sat, Apr 18, 6:48 PM
Herald added subscribers: ziaee, olce, imp. · View Herald TranscriptSat, Apr 18, 6:48 PM
kib requested review of this revision.Sat, Apr 18, 6:48 PM
rbranco_suse.com added a subscriber: rbranco_suse.com.Sat, Apr 18, 7:24 PM

I succesfully tested the current patch with my suggestions along with https://github.com/freebsd/freebsd-src/pull/2147

sys/kern/kern_membarrier.c
124
230

Need to declare int res = 0

234
236
sys/sys/membarrier.h
52

This value collides with MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ below.

kib updated this revision to Diff 175850.Sat, Apr 18, 7:39 PM
kib marked 5 inline comments as done.
kib added a reviewer: markj.

Branko' feedback.

rbranco_suse.com accepted this revision.Sat, Apr 18, 7:56 PM
This revision is now accepted and ready to land.Sat, Apr 18, 7:56 PM

Revision Contents
Changeset List

PathSize
lib/
libsys/
6 lines
sys/
kern/
31 lines
sys/
3 lines

Diff 175850

View Options

lib/libsys/membarrier.2

Loading...
View Options

sys/kern/kern_membarrier.c

Loading...
View Options

sys/sys/membarrier.h

Loading...