Differential D56416

pkru.3: Note that the kernel may not respect PKRU protections
ClosedPublic
Actions

Authored by markj on Wed, Apr 15, 5:49 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 19, 6:48 AM

	Unknown Object (File)
	Sat, Apr 18, 6:21 AM

	Unknown Object (File)
	Sat, Apr 18, 6:21 AM

	Unknown Object (File)
	Sat, Apr 18, 6:21 AM

	Unknown Object (File)
	Sat, Apr 18, 6:21 AM

	Unknown Object (File)
	Sat, Apr 18, 5:25 AM

	Unknown Object (File)
	Fri, Apr 17, 6:14 PM

	Unknown Object (File)
	Fri, Apr 17, 2:01 PM

View All 10 Files

Subscribers

Details

Reviewers

alc
kib

Commits

rGfa77fecb0e06: pkru.3: Note that the kernel may not respect PKRU protections

Summary

There are cases where the kernel will be able to access memory covered
by a PKRU key which nomially prohibits accesses. I believe regular
copyin()/copyout() are subject to the contents of PKRU, but memory
accesses via uiomove_fromphys() will not be. This can arise when
performing fault I/O, for instance. I didn't test, but I suspect AIO is
another case.

Update the man page to acknowledge this.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 72252
Build 69135: arc lint + arc unit

Event Timeline

markj created this revision.Wed, Apr 15, 5:49 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptWed, Apr 15, 5:49 PM

markj requested review of this revision.Wed, Apr 15, 5:49 PM

Harbormaster completed remote builds in B72235: Diff 175591.Wed, Apr 15, 5:49 PM

markj added a parent revision: D56415: pkru.3: Remove a qualifier.Wed, Apr 15, 5:49 PM

kib added inline comments.Wed, Apr 15, 11:13 PM

lib/libsys/x86/pkru.3
76
78

Handle kib's notes.

Harbormaster completed remote builds in B72252: Diff 175624.Thu, Apr 16, 12:55 PM

kib accepted this revision.Thu, Apr 16, 1:33 PM

kib added inline comments.

lib/libsys/x86/pkru.3
75

This revision is now accepted and ready to land.Thu, Apr 16, 1:33 PM

kib added inline comments.Thu, Apr 16, 2:41 PM

lib/libsys/x86/pkru.3
75	'the synchronous signal' even

alc added inline comments.Thu, Apr 16, 3:46 PM

lib/libsys/x86/pkru.3
75	consider "... PKRU register, the offending thread receives a SIGSEGV signal with ..."

Handle feedback

This revision now requires review to proceed.Thu, Apr 16, 4:36 PM

Harbormaster completed remote builds in B72258: Diff 175677.Thu, Apr 16, 4:37 PM

alc accepted this revision.Thu, Apr 16, 4:41 PM

This revision is now accepted and ready to land.Thu, Apr 16, 4:41 PM

Closed by commit rGfa77fecb0e06: pkru.3: Note that the kernel may not respect PKRU protections (authored by markj). · Explain WhyThu, Apr 16, 5:46 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGfa77fecb0e06: pkru.3: Note that the kernel may not respect PKRU protections.

Revision Contents
Changeset List

Path

Size

lib/

libsys/

x86/

18 lines

Diff 175624

lib/libsys/x86/pkru.3

Loading...