Page MenuHomeFreeBSD
Differential D56396

LinuxKPI: implement devm_kmemdup_array()
ClosedPublic
Actions

Authored by bz on Tue, Apr 14, 3:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 24, 1:48 AM
Unknown Object (File)
Tue, Apr 21, 3:38 AM
Unknown Object (File)
Mon, Apr 20, 7:42 PM
Unknown Object (File)
Mon, Apr 20, 11:16 AM
Unknown Object (File)
Mon, Apr 20, 7:21 AM
Unknown Object (File)
Sun, Apr 19, 9:44 PM
Unknown Object (File)
Sun, Apr 19, 8:34 AM
Unknown Object (File)
Sun, Apr 19, 6:08 AM
View All 12 Files
Subscribers
dumbbell
emaste
imp

Details

Reviewers
dumbbell
Group Reviewers
linuxkpi
Commits
rGedbcaca4353c: LinuxKPI: implement devm_kmemdup_array()
rGf1834d03af61: LinuxKPI: implement devm_kmemdup_array()
Summary

Implement devm_kmemdup_array() using devm_kmemdup() in order to
prepare for Linux v7.0 based drivers.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 72205
Build 69088: arc lint + arc unit

Event Timeline

bz created this revision.Tue, Apr 14, 3:35 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptTue, Apr 14, 3:35 PM
bz requested review of this revision.Tue, Apr 14, 3:35 PM
Harbormaster completed remote builds in B72205: Diff 175513.Tue, Apr 14, 3:35 PM
bz added a parent revision: D56395: LinuxKPI: add kmalloc_obj[s], kzalloc_obj[s], and kzalloc_flex.Tue, Apr 14, 3:37 PM
dumbbell added a subscriber: dumbbell.Wed, Apr 15, 8:38 PM

The devm_kmemdup*() functions are defined in <linux/device/devres.h>, included from <linux/device.h> in 7.0. Did you consider adding them to <linux/device/devres.h>?

bz added a comment.Wed, Apr 15, 8:44 PM
In D56396#1291571, @dumbbell wrote:

The devm_kmemdup*() functions are defined in <linux/device/devres.h>, included from <linux/device.h> in 7.0. Did you consider adding them to <linux/device/devres.h>?

No, I haven't checked what Linux does for this.
I think factoring them out, I'd rather do in a dedicated commit not adding new stuff.
I can prepare that as a follow-up.

dumbbell accepted this revision.Wed, Apr 15, 9:02 PM

I understand, thanks. I'm approving this patch then.

This revision is now accepted and ready to land.Wed, Apr 15, 9:02 PM
Closed by commit rGf1834d03af61: LinuxKPI: implement devm_kmemdup_array() (authored by bz). · Explain WhySat, Apr 18, 1:13 AM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rGf1834d03af61: LinuxKPI: implement devm_kmemdup_array().
bz added a commit: rGedbcaca4353c: LinuxKPI: implement devm_kmemdup_array().Wed, Apr 22, 9:13 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
7 lines

Diff 175513

View Options

sys/compat/linuxkpi/common/include/linux/device.h

Loading...