Paths

Table of Contentst

tests: kqueue: improve diagnostics for our CPONFORK test
ClosedPublic
Actions

Authored by kevans on Apr 13 2026, 4:40 AM.

Details

Reviewers

kib
markj

Commits

rG51d2c3801082: tests: kqueue: improve diagnostics for our CPONFORK test

Summary

Notably, confirm in the child that our close-on-fork fd is actually
closed, and break RECV_ALL out into a table and check each bit
individually to provide a better message when the test fails.

While we're here, just switch to waitid() rather than trying to identify
the point where we have to make the switch. This reduces maintenance
slightly, as keeping our assertion static would require still adding to
a _RECV_ALL mask *just* for that purpose.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 72170
Build 69053: arc lint + arc unit

Event Timeline

kevans created this revision.Apr 13 2026, 4:40 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 13 2026, 4:40 AM

kevans requested review of this revision.Apr 13 2026, 4:40 AM

Harbormaster completed remote builds in B72170: Diff 175406.Apr 13 2026, 4:40 AM

kib accepted this revision.Apr 13 2026, 10:34 AM

kib added inline comments.

tests/sys/kqueue/kqueue_fork.c
116

This revision is now accepted and ready to land.Apr 13 2026, 10:34 AM

kevans marked an inline comment as done.Apr 13 2026, 1:56 PM

kevans added inline comments.

tests/sys/kqueue/kqueue_fork.c
116	Fitting within single 80 columns, maybe: `expect = childmask && rcv->recv_parent_only ? 0 : rcv->recv_bit;` -> I note that childmask and recv_parent_only are both actually bool, so should be fine? I mainly hadn't ternary'd it initially because I hate the aesthetics when they have to wrap, but maybe not so bad.

kib added inline comments.Apr 13 2026, 8:09 PM

tests/sys/kqueue/kqueue_fork.c
116	I prefer ternary op becase it avoids repeating assignment to the same variable it puts more code on the same sized screen or emacs window

markj accepted this revision.Apr 15 2026, 2:05 PM

markj added inline comments.

tests/sys/kqueue/kqueue_fork.c
58	I would keep this closer to the actual definition of the test. I know our style guide wants global variables defined first but for tests that makes less sense IMO.
273	This doesn't need to be `WEXITSTATUS(info.si_status)`?

kevans marked an inline comment as done.Apr 15 2026, 2:34 PM

kevans added inline comments.

tests/sys/kqueue/kqueue_fork.c
273	With siginfo, `si_status` preserves the exit status faithfully because the reason is stored out of band in `si_code`instead.

kevans marked 2 inline comments as done.Apr 15 2026, 2:35 PM

kevans marked an inline comment as done.Apr 15 2026, 3:50 PM

Closed by commit rG51d2c3801082: tests: kqueue: improve diagnostics for our CPONFORK test (authored by kevans). · Explain WhyApr 17 2026, 3:57 AM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rG51d2c3801082: tests: kqueue: improve diagnostics for our CPONFORK test.

Revision Contents
Changeset List

Path

Size

tests/

sys/

kqueue/

kqueue_fork.c

87 lines

Diff 175406

View Options

tests/sys/kqueue/kqueue_fork.c

tests: kqueue: improve diagnostics for our CPONFORK testClosedPublicActions