Page MenuHomeFreeBSD
Differential D830

Assert that malloc(9) and uma_zalloc_arg(9) are not called from non-sleepable threads or interrupts.
Needs ReviewPublic
Actions

Authored by bdrewery on Sep 25 2014, 1:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 16 2024, 12:32 PM
Unknown Object (File)
Dec 29 2023, 5:39 PM
Unknown Object (File)
Dec 20 2023, 12:48 AM
Unknown Object (File)
Dec 6 2023, 11:28 PM
Unknown Object (File)
Nov 11 2023, 6:40 AM
Unknown Object (File)
Nov 10 2023, 8:18 PM
Unknown Object (File)
Nov 6 2023, 9:30 AM
Unknown Object (File)
Nov 1 2023, 12:21 AM
View All 65 Files
Subscribers
imp
markj
ngie
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

KASSERT_WARN() is used for now since the impact is not known.

This is based on the patch and report from https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193696

A problem I know of is that malloc(9) calls uma_zalloc(9) and due to the non-panic KASSERT_WARN, it shows the same message again. It would not make sense to only place the KASSERT_WARN only in uma_zalloc_arg(9) for now as then memguard and redzone would be missing the check.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bdrewery updated this revision to Diff 1750.Sep 25 2014, 1:05 AM
bdrewery retitled this revision from to Assert that malloc(9) and uma_zalloc_arg(9) are not called from non-sleepable threads or interrupts..
bdrewery updated this object.
bdrewery edited the test plan for this revision. (Show Details)
bdrewery added a parent revision: D829: Add KASSERT_WARN.Sep 25 2014, 1:06 AM
bdrewery updated this object.
bdrewery updated this object.Sep 25 2014, 1:08 AM
ngie added a subscriber: ngie.Sep 25 2014, 1:46 AM

Changes LGTM once D829 is in.

bdrewery updated this revision to Diff 1764.Sep 25 2014, 3:51 PM

Remove use of KASSERT_WARN for interrupt check in uma_zallog_arg() and move
the KASSERTS for interrupt contexts outside of the M_WAITOK check.

Updating D830: Assert that malloc(9) and uma_zalloc_arg(9) are not called from non-sleepable

threads or interrupts.

bdrewery updated this revision to Diff 1765.Sep 25 2014, 3:51 PM

Whitespace

Updating D830: Assert that malloc(9) and uma_zalloc_arg(9) are not called from non-sleepable

threads or interrupts.

emaste added a subscriber: markj.Nov 15 2018, 8:23 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 15 2018, 8:23 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
5 lines
vm/
4 lines

Diff 1750

View Options

sys/kern/kern_malloc.c

Loading...
View Options

sys/vm/uma_core.c

Loading...