Page MenuHomeFreeBSD

Add KASSERT_WARN
Needs ReviewPublic

Authored by bdrewery on Sep 25 2014, 1:04 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

KASSERT_WARN is for adding KASSERTS where the impact is unknown but it makes
sense to check for the condition. It is expected that the use would
eventually be changed to a full KASSERT.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

bdrewery retitled this revision from to Add KASSERT_WARN.
bdrewery updated this object.
bdrewery edited the test plan for this revision. (Show Details)
ngie added inline comments.
sys/kern/kern_shutdown.c
617

Should "fatal" be boolean?

627–628

I would update the comment here to add in "fatal".

sys/sys/systm.h
91

Existing style(9) bugs in the macro with a space missing between exp and msg?

sys/kern/kern_shutdown.c
617

I'm not sure. I almost went with boolean but am unclear on its acceptance in kernel code.

emaste added inline comments.
sys/kern/kern_shutdown.c
617

style(9) now mentions boolean, and for new code I believe we should use it.