Add KASSERT_WARN
Needs ReviewPublic
Actions

Authored by bdrewery on Sep 25 2014, 1:04 AM.

Tags

None

Referenced Files

	F173372720: D829.id1749.diff
	Fri, Sep 25, 12:57 PM

	F173360695: D829.diff
	Fri, Sep 25, 11:00 AM

	Unknown Object (File)
	Thu, Sep 24, 1:24 AM

	Unknown Object (File)
	Fri, Sep 11, 4:36 AM

	Unknown Object (File)
	Thu, Sep 10, 6:40 PM

	Unknown Object (File)
	Sat, Sep 5, 5:50 PM

	Unknown Object (File)
	Sat, Sep 5, 3:53 AM

	Unknown Object (File)
	Thu, Sep 3, 9:29 PM

Subscribers

This revision needs review, but there are no reviewers specified.

Details

Reviewers: None

Summary

KASSERT_WARN is for adding KASSERTS where the impact is unknown but it makes
sense to check for the condition. It is expected that the use would
eventually be changed to a full KASSERT.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bdrewery updated this revision to Diff 1749.Sep 25 2014, 1:04 AM

bdrewery retitled this revision from to Add KASSERT_WARN.

bdrewery updated this object.

bdrewery edited the test plan for this revision. (Show Details)

ngie added a subscriber: ngie.Sep 25 2014, 1:42 AM

ngie added inline comments.

sys/kern/kern_shutdown.c
617	Should "fatal" be boolean?
627–628	I would update the comment here to add in "fatal".
sys/sys/systm.h
91	Existing style(9) bugs in the macro with a space missing between exp and msg?