ping6: treat setsockopt failures as fatal
ClosedPublic
Actions

Authored by chris.longros_gmail.com on Fri, Apr 3, 3:13 PM.

Details

Reviewers

jlduran
des
pouria
glebius

Group Reviewers

network

Commits

rG9a4a9f623bba: ping6: treat setsockopt failures as fatal

Summary

ping6 needs IPV6_RECVPKTINFO and IPV6_RECVHOPLIMIT to process
incoming replies. When these options fail, replies are silently
dropped and ping6 appears to hang. Use err(3) instead of warn(3)
so the user gets a clear error and immediate exit.

Signed-off-by: Christos Longros <chris.longros@gmail.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 71938
Build 68821: arc lint + arc unit

Event Timeline

chris.longros_gmail.com created this revision.Fri, Apr 3, 3:13 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Apr 3, 3:13 PM

chris.longros_gmail.com requested review of this revision.Fri, Apr 3, 3:13 PM

Harbormaster completed remote builds in B71938: Diff 174861.Fri, Apr 3, 3:13 PM

chris.longros_gmail.com added reviewers: jlduran, des.Fri, Apr 3, 3:13 PM

jlduran accepted this revision.Tue, Apr 7, 11:51 AM

This revision is now accepted and ready to land.Tue, Apr 7, 11:51 AM

@jlduran Hi, this has been accepted — could you commit it? Thanks!

jlduran added a reviewer: network.Thu, Apr 16, 5:22 PM

Yes, this should be pretty straightforward.
I added the network project, just in case. Let's wait one more week, plus an MFC of one week after that.
If this is time-sensitive, let me know and I will commit sooner. Thank you!

LGTM, but I can't test it because almost all of those values are validated before reaching those lines.
I would appreciate it if you could provide steps to reproduce.

I don't think it is possible to reproduce that. The program always passes correct optval to a correct socket. The flag enabling setsockopt() shall never fail in the kernel. Treat that more as a stylistic change. It might be useful for FreeBSD-derived projects, e.g. if Mac OS X refreshes their ping(1) with our ping, as they already did in the past, and their kernel may fail at these setsockopts.

Closed by commit rG9a4a9f623bba: ping6: treat setsockopt failures as fatal (authored by chris.longros_gmail.com, committed by jlduran). · Explain WhyFri, Apr 17, 6:22 PM

This revision was automatically updated to reflect the committed changes.

jlduran added a commit: rG9a4a9f623bba: ping6: treat setsockopt failures as fatal.