Differential D56050

hwpmc.4: correct stale default values and update diagnostics
ClosedPublic
Actions

Authored by paulo_nlink.com.br on Mon, Mar 23, 5:11 PM.

Tags

None

Referenced Files

	F153179449: D56050.diff
	Sun, Apr 19, 3:35 PM

	Unknown Object (File)
	Sat, Apr 18, 2:19 PM

	Unknown Object (File)
	Wed, Apr 15, 3:02 AM

	Unknown Object (File)
	Wed, Apr 15, 12:44 AM

	Unknown Object (File)
	Tue, Apr 14, 10:52 AM

	Unknown Object (File)
	Thu, Apr 2, 6:37 PM

	Unknown Object (File)
	Wed, Apr 1, 4:38 AM

	Unknown Object (File)
	Mon, Mar 30, 7:48 PM

View All 16 Files

Subscribers

Details

Reviewers

ali_mashtizadeh.com
gnn
mhorne

Commits

rG928091964581: hwpmc.4: correct stale default values and update diagnostics
rG2318ea10a3af: hwpmc.4: correct stale default values and update diagnostics

Summary

The default values documented for kern.hwpmc.logbuffersize (4KB) and
kern.hwpmc.nbuffers_pcpu (64) have been incorrect since 2981a3420cb1
(2018), which updated the compiled defaults but did not update the
man page.

Correct logbuffersize default from 4KB to 256KB, add 16MB maximum
Correct nbuffers_pcpu default from 64 to 32, document 32MB per-CPU product limit with kern.hwpmc.logbuffersize
Update DIAGNOSTICS section to reflect current warning messages

Sponsored by: NLINK (nlink.com.br)

Test Plan

Verified rendered output with:

man -l share/man/man4/hwpmc.4

mandoc -T lint shows only one pre-existing warning
(IMPLEMENTATION NOTES section order, not introduced by this patch).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

paulo_nlink.com.br created this revision.Mon, Mar 23, 5:11 PM

Herald added a reviewer: gnn. · View Herald TranscriptMon, Mar 23, 5:11 PM

Herald added subscribers: ziaee, imp. · View Herald Transcript

paulo_nlink.com.br requested review of this revision.Mon, Mar 23, 5:11 PM

Harbormaster completed remote builds in B71673: Diff 174176.Mon, Mar 23, 5:11 PM

mhorne accepted this revision.Mon, Mar 23, 5:31 PM

This revision is now accepted and ready to land.Mon, Mar 23, 5:31 PM

Closed by commit rG2318ea10a3af: hwpmc.4: correct stale default values and update diagnostics (authored by paulo_nlink.com.br, committed by mhorne). · Explain WhyMon, Mar 23, 8:22 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG2318ea10a3af: hwpmc.4: correct stale default values and update diagnostics.

mhorne added a commit: rG928091964581: hwpmc.4: correct stale default values and update diagnostics.Thu, Apr 16, 3:30 PM

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

25 lines

Diff 174183

share/man/man4/hwpmc.4

Loading...