Page MenuHomeFreeBSD
Differential D56034

tunefs: Add tests
AcceptedPublic
Actions

Authored by des on Sun, Mar 22, 6:59 PM.

Details

Reviewers
ngie
Group Reviewers
tests
Summary

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71646
Build 68529: arc lint + arc unit

Event Timeline

des created this revision.Sun, Mar 22, 6:59 PM
Herald added subscribers: ivy, imp. · View Herald TranscriptSun, Mar 22, 6:59 PM
des requested review of this revision.Sun, Mar 22, 6:59 PM
Harbormaster completed remote builds in B71646: Diff 174132.Sun, Mar 22, 6:59 PM
des added a parent revision: D56033: tunefs: Don't lower WARNS.Sun, Mar 22, 6:59 PM
des added a reviewer: tests.Sun, Mar 22, 7:00 PM
des added a parent revision: D56010: file: Parse some UFS2 flags.Sun, Mar 22, 7:03 PM
ngie accepted this revision.Tue, Mar 24, 4:24 PM
ngie added a subscriber: ngie.
ngie added inline comments.
sbin/tunefs/tests/tunefs_test.sh
15–50

Most of my recommendations are to just make the function a bit easier for humans to follow and for the function to be easier to maintain in the future.

95–185

I think you could use su instead of sunoj for brevity.

This revision is now accepted and ready to land.Tue, Mar 24, 4:24 PM

Revision Contents
Changeset List

PathSize
etc/
mtree/
2 lines
sbin/
tunefs/
5 lines
tests/
4 lines
189 lines

Diff 174132

View Options

etc/mtree/BSD.tests.dist

Loading...
View Options

sbin/tunefs/Makefile

Loading...
View Options

sbin/tunefs/tests/Makefile

Loading...
View Options

sbin/tunefs/tests/tunefs_test.sh

Loading...