Page MenuHomeFreeBSD
Differential D55941

sound: Do not create root feeder in chn_init()
ClosedPublic
Actions

Authored by christos on Mar 19 2026, 3:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 15, 7:38 AM
Unknown Object (File)
Wed, Jul 15, 7:13 AM
Unknown Object (File)
Wed, Jul 15, 7:13 AM
Unknown Object (File)
Fri, Jul 10, 10:35 PM
Unknown Object (File)
Mon, Jul 6, 7:02 AM
Unknown Object (File)
Mon, Jul 6, 5:37 AM
Unknown Object (File)
Sun, Jul 5, 9:04 PM
Unknown Object (File)
Sun, Jul 5, 8:22 PM
View All 40 Files
Subscribers
imp

Details

Reviewers
markj
emaste
Commits
rG7c483aa01363: sound: Do not create root feeder in chn_init()
rGb9f9fc473eb5: sound: Do not create root feeder in chn_init()
Summary

The feeder chain gets destroyed when feeder_chain() is called, which is
after the chn_reset() call in chn_init() further down for primary chans,
or vchan_create() for vchans. This makes the root feeder creation in
chn_init() essentially a no-op. Remove it altogether and let
feeder_chain() after chn_reset() take care of creating the feeder
properly. It creates the root one as well.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71519
Build 68402: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
12 lines

Diff 173908

View Options

sys/dev/sound/pcm/channel.c

Loading...