Differential D55250

arm64: Have a common call to userret
ClosedPublic
Actions

Authored by andrew on Feb 11 2026, 6:13 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 5, 7:14 AM

	Unknown Object (File)
	Sat, Apr 4, 5:05 AM

	Unknown Object (File)
	Sat, Mar 28, 2:24 AM

	Unknown Object (File)
	Fri, Mar 27, 11:31 AM

	Unknown Object (File)
	Fri, Mar 27, 8:08 AM

	Unknown Object (File)
	Fri, Mar 27, 8:08 AM

	Unknown Object (File)
	Fri, Mar 27, 6:55 AM

	Unknown Object (File)
	Tue, Mar 17, 10:18 PM

View All 23 Files

Subscribers

Details

Reviewers

kib
manu

Group Reviewers

Commits

rG14e97448fceb: arm64: Have a common call to userret

Summary

Rather than each exception calling userret use a common copy. As
syscallret already calls userret we need to skip it in that case.

Sponsored by: Arm Ltd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71457
Build 68340: arc lint + arc unit

Event Timeline

andrew created this revision.Feb 11 2026, 6:13 PM

Herald added a reviewer: manu. · View Herald TranscriptFeb 11 2026, 6:13 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Feb 11 2026, 6:13 PM

Harbormaster completed remote builds in B70624: Diff 171772.Feb 11 2026, 6:13 PM

IMHO the control flow could be made less confusing. Right now it is 'break' -> userret, and in one place it is goto no_userret. I suggest to add a control variable like 'use_userret', set to true, assigned from svc_handler() return value. Then instead of goto no userret. check the value of use_userret around userret() call. Hope it is understandable.

This revision is now accepted and ready to land.Feb 12 2026, 6:37 AM

Set a variable to check if we need to skip userret

This revision now requires review to proceed.Mar 5 2026, 3:42 PM

Harbormaster completed remote builds in B71199: Diff 173200.Mar 5 2026, 3:42 PM

kib added inline comments.Mar 6 2026, 1:20 AM

sys/arm64/arm64/trap.c
700	Should this be false?

Fix the initial value of skip_userret

Harbormaster completed remote builds in B71453: Diff 173798.Tue, Mar 17, 9:51 AM

Remove userret from EXCP_MOE. Was missed in a rebase.

Harbormaster completed remote builds in B71457: Diff 173806.Tue, Mar 17, 1:59 PM

kib accepted this revision.Tue, Mar 17, 2:30 PM

This revision is now accepted and ready to land.Tue, Mar 17, 2:30 PM

Closed by commit rG14e97448fceb: arm64: Have a common call to userret (authored by andrew). · Explain WhyTue, Mar 17, 5:12 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG14e97448fceb: arm64: Have a common call to userret.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

arm64/

30 lines

Diff 173806

sys/arm64/arm64/trap.c

Loading...