Page MenuHomeFreeBSD
Differential D55631

axge: fix spurious link down from MII, frozen TX
Needs ReviewPublic
Actions

Authored by rkitover_gmail.com on Tue, Mar 3, 1:11 PM.
Tags
Referenced Files
Unknown Object (File)
Fri, Mar 13, 9:52 PM
Unknown Object (File)
Fri, Mar 13, 2:15 PM
Unknown Object (File)
Wed, Mar 11, 7:09 AM
Unknown Object (File)
Sun, Mar 8, 2:04 PM
Unknown Object (File)
Sun, Mar 8, 1:57 PM
Unknown Object (File)
Sun, Mar 8, 8:25 AM
Unknown Object (File)
Thu, Mar 5, 1:50 AM
Unknown Object (File)
Thu, Mar 5, 1:34 AM
View All 13 Files
Subscribers
imp
pouria

Details

Reviewers
adrian
Group Reviewers
USB
network
Summary

A race condition in the MII layer causes spurious link down events, see:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252165

. In statchg, on link down, check if the PHY reports the link as
actually down using the BMSR register, if not, force the status of the
link to back up and restart TX. Do the same in a MII linkchg handler.

On actual link up, restart TX in case it went idle and down.

I have tested this patch with two of my USB-C hubs with this Ethernet
interface, and it gives me a stable permanent connection with no
interruptions to my internet connections.

Signed-off-by: Rafael Kitover <rkitover@gmail.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71153
Build 68036: arc lint + arc unit

Event Timeline

rkitover_gmail.com created this revision.Tue, Mar 3, 1:11 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, Mar 3, 1:11 PM
rkitover_gmail.com requested review of this revision.Tue, Mar 3, 1:11 PM
Harbormaster completed remote builds in B71152: Diff 173057.Tue, Mar 3, 1:11 PM
rkitover_gmail.com updated this revision to Diff 173058.Tue, Mar 3, 1:14 PM

Add Differential Review URL

Add Differential Review URL to commit message.

Harbormaster completed remote builds in B71153: Diff 173058.Tue, Mar 3, 1:14 PM
rkitover_gmail.com added projects: network, USB.Tue, Mar 3, 1:23 PM
rkitover_gmail.com added reviewers: adrian, USB, network.
rkitover_gmail.com added a comment.Tue, Mar 3, 1:28 PM

Started as pull request here:

https://github.com/freebsd/freebsd-src/pull/2037

rkitover_gmail.com added a child revision: D55682: ure: fix spurious link flaps from MII.Fri, Mar 6, 1:27 AM
rkitover_gmail.com updated this revision to Diff 173262.Fri, Mar 6, 12:33 PM

Update for style(9)

Harbormaster completed remote builds in B71227: Diff 173262.Fri, Mar 6, 12:33 PM
rkitover_gmail.com updated this revision to Diff 173265.Fri, Mar 6, 12:39 PM

Update for style(9)

Harbormaster completed remote builds in B71229: Diff 173265.Fri, Mar 6, 12:39 PM
rkitover_gmail.com mentioned this in D55682: ure: fix spurious link flaps from MII.Fri, Mar 6, 12:42 PM
pouria added a subscriber: pouria.Tue, Mar 10, 5:58 PM

style.9

sys/dev/usb/net/if_axge.c
334

use bool for new_link and old_link

392–394

Up to your judgement, but try to not break strings as much as possible.

488

style: Do not test without a comparison, or with unary ! (except for booleans).

rkitover_gmail.com updated this revision to Diff 173586.Wed, Mar 11, 8:33 PM

Update for style(9)

Harbormaster completed remote builds in B71349: Diff 173586.Wed, Mar 11, 8:33 PM
rkitover_gmail.com marked 2 inline comments as done.Wed, Mar 11, 8:34 PM
rkitover_gmail.com marked an inline comment as done.Thu, Mar 12, 11:01 AM

I think I can remove the frozen TX fix given that the link doesn't go down, I'll do that and test it out, then update this patch.

pouria, I still want your ure logs, with and without the patch, I need to figure out why it didn't work for you as intended.

rkitover_gmail.com updated this revision to Diff 173603.Thu, Mar 12, 11:14 AM

Remove frozen TX handling, unneeded if link up

Harbormaster completed remote builds in B71361: Diff 173603.Thu, Mar 12, 11:14 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
usb/
net/
89 lines

Diff 173058

View Options

sys/dev/usb/net/if_axge.c

Loading...