Page MenuHomeFreeBSD
Differential D56138

ure: lock MII bus operations
Needs ReviewPublic
Actions

Authored by rkitover_gmail.com on Mar 28 2026, 10:50 PM.
Tags
Referenced Files
Unknown Object (File)
Tue, Sep 15, 7:24 PM
Unknown Object (File)
Fri, Sep 11, 5:49 PM
Unknown Object (File)
Fri, Sep 11, 3:08 AM
Unknown Object (File)
Fri, Sep 11, 3:03 AM
Unknown Object (File)
Thu, Sep 10, 7:29 PM
Unknown Object (File)
Tue, Sep 8, 8:10 PM
Unknown Object (File)
Tue, Sep 8, 4:20 PM
Unknown Object (File)
Tue, Sep 8, 10:08 AM
View All Files
Subscribers
imp

Details

Reviewers
adrian
sanpei
pouria
zlei
Summary

A race condition in the MII layer causes spurious events, see:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252165

. Use a lock to serialize access to MII operations and drop ticks when
MII is locked.

Signed-off-by: Rafael Kitover <rkitover@gmail.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 73863
Build 70746: arc lint + arc unit

Event Timeline

rkitover_gmail.com created this revision.Mar 28 2026, 10:50 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 28 2026, 10:50 PM
rkitover_gmail.com requested review of this revision.Mar 28 2026, 10:50 PM
Harbormaster completed remote builds in B71787: Diff 174463.Mar 28 2026, 10:50 PM
rkitover_gmail.com updated this revision to Diff 174464.Mar 28 2026, 10:50 PM
rkitover_gmail.com added a parent revision: D55682: ure: fix spurious link flaps from MII.

Add Differential Revision

Harbormaster completed remote builds in B71788: Diff 174464.Mar 28 2026, 10:52 PM
rkitover_gmail.com added projects: USB, desktop.Mar 28 2026, 10:53 PM
rkitover_gmail.com added reviewers: adrian, sanpei, pouria, zlei.
rkitover_gmail.com mentioned this in D55682: ure: fix spurious link flaps from MII.Mar 28 2026, 10:55 PM
pouria added a comment.Mar 29 2026, 12:12 PM

I'd be happy to review this, but I need reproduction steps.

sanpei added a comment.Mar 29 2026, 1:13 PM

Hi @pouria.

I can reproduce below steps

Device: Raspberry Pi Zero 2W(arm64)
OS: 15.0-RELEASE + (D55682) (maybe also -current)
Setup : CARP configured on the ure interface.
Dongle: Lenovo USB-C to LAN

Steps:
Machine A (Remote): Run ping [Unassigned Local IP].
Machine B (Target): Run the route -n monitor command in four separate instances and more.

Result: NG (Failed)

and this change is fixed(I'm still testing some devices. After finish, I will report it)

rkitover_gmail.com added a comment.Mar 31 2026, 2:30 AM

Does anyone know how I can get an adapter or hub device with the C variant chip (latest revision?)

rkitover_gmail.com updated this revision to Diff 174723.Apr 1 2026, 9:02 AM

Fix style based on zlei's review

Harbormaster completed remote builds in B71897: Diff 174723.Apr 1 2026, 9:02 AM
sanpei mentioned this in D56985: usb_ethernet: avoid ioctl and watchdog tick link up/down race condition..May 18 2026, 12:29 PM
rkitover_gmail.com updated this revision to Diff 179319.Jun 5 2026, 11:35 PM

Keep only MII bus lock, it's enough.

Harbormaster completed remote builds in B73720: Diff 179319.Jun 5 2026, 11:35 PM
rkitover_gmail.com mentioned this in D55631: axge: fix spurious link down from MII, frozen TX.Jun 6 2026, 2:09 PM
rkitover_gmail.com updated this revision to Diff 179710.Jun 14 2026, 5:18 AM

Remove PHY checking, MII bus lock is sufficient

Harbormaster completed remote builds in B73863: Diff 179710.Jun 14 2026, 5:19 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
usb/
net/
94 lines
4 lines

Diff 179710

View Options

sys/dev/usb/net/if_ure.c

Loading...
View Options

sys/dev/usb/net/if_urereg.h

Loading...