Paths

Table of Contentst

Differential D55631

axge: fix spurious link down from MII, frozen TX
Needs ReviewPublic
Actions

Authored by rkitover_gmail.com on Tue, Mar 3, 1:11 PM.

Tags

Referenced Files

	Unknown Object (File)
	Sun, Mar 8, 2:04 PM

	Unknown Object (File)
	Sun, Mar 8, 1:57 PM

	Unknown Object (File)
	Sun, Mar 8, 8:25 AM

	Unknown Object (File)
	Thu, Mar 5, 1:50 AM

	Unknown Object (File)
	Thu, Mar 5, 1:34 AM

	Unknown Object (File)
	Thu, Mar 5, 12:29 AM

	Unknown Object (File)
	Wed, Mar 4, 11:14 PM

	Unknown Object (File)
	Wed, Mar 4, 11:05 PM

View All 10 Files

Subscribers

Details

Reviewers

Group Reviewers

USB
network

Summary

A race condition in the MII layer causes spurious link down events, see:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252165

. In statchg, on link down, check if the PHY reports the link as
actually down using the BMSR register, if not, force the status of the
link to back up and restart TX. Do the same in a MII linkchg handler.

On actual link up, restart TX in case it went idle and down.

I have tested this patch with two of my USB-C hubs with this Ethernet
interface, and it gives me a stable permanent connection with no
interruptions to my internet connections.

Signed-off-by: Rafael Kitover <rkitover@gmail.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71152
Build 68035: arc lint + arc unit

Event Timeline

rkitover_gmail.com created this revision.Tue, Mar 3, 1:11 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Mar 3, 1:11 PM

rkitover_gmail.com requested review of this revision.Tue, Mar 3, 1:11 PM

Harbormaster completed remote builds in B71152: Diff 173057.Tue, Mar 3, 1:11 PM

Add Differential Review URL

Add Differential Review URL to commit message.

Harbormaster completed remote builds in B71153: Diff 173058.Tue, Mar 3, 1:14 PM

rkitover_gmail.com added projects: network, USB.Tue, Mar 3, 1:23 PM

rkitover_gmail.com added reviewers: adrian, USB, network.

Started as pull request here:

https://github.com/freebsd/freebsd-src/pull/2037

rkitover_gmail.com added a child revision: D55682: ure: fix spurious link flaps from MII.Fri, Mar 6, 1:27 AM

Update for style(9)

Harbormaster completed remote builds in B71227: Diff 173262.Fri, Mar 6, 12:33 PM

Update for style(9)

Harbormaster completed remote builds in B71229: Diff 173265.Fri, Mar 6, 12:39 PM

rkitover_gmail.com mentioned this in D55682: ure: fix spurious link flaps from MII.Fri, Mar 6, 12:42 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

net/

89 lines

Diff 173057

sys/dev/usb/net/if_axge.c

Loading...