ed: add unicode support for the l (list) command
ClosedPublic
Actions

Authored by bapt on Feb 19 2026, 10:03 AM.

Details

Reviewers: None
Commits: rG5df6aca10906: ed: add unicode support for the l (list) command

Summary

Use mbrtowc()/iswprint()/wcwidth() in put_tty_line() so that
the l command displays valid multibyte characters as-is instead
of escaping each byte as octal.

Column wrapping now correctly accounts for character display
width (including double-width CJK characters).

Invalid or incomplete UTF-8 sequences and non-printable
characters are still escaped as octal.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70778
Build 67661: arc lint + arc unit

Event Timeline

bapt created this revision.Feb 19 2026, 10:03 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 19 2026, 10:03 AM

bapt requested review of this revision.Feb 19 2026, 10:03 AM

bapt added a parent revision: D55364: ed: add unicode test cases to ATF test suite.

Harbormaster completed remote builds in B70770: Diff 172214.Feb 19 2026, 10:04 AM

Do regexps addresses and commands like 's' correctly operate on mb strings?

yes it does, all the tests in https://reviews.freebsd.org/D55364 are passing with this patch.

I may be missing some idea on what to test

In D55365#1266392, @bapt wrote:

I may be missing some idea on what to test

Might be add some tests for e.g. ru_RU.UTF-8? What do you need for this?

In D55365#1266404, @kib wrote:

In D55365#1266392, @bapt wrote:

I may be missing some idea on what to test

Might be add some tests for e.g. ru_RU.UTF-8? What do you need for this?

juste provide me a set of command you would expect to work in ru_RU.UTF-8 and and expected output and I will add it to the test suite.

In D55365#1266416, @bapt wrote:

In D55365#1266404, @kib wrote:

In D55365#1266392, @bapt wrote:

I may be missing some idea on what to test

Might be add some tests for e.g. ru_RU.UTF-8? What do you need for this?

In D55365#1266404, @kib wrote:

In D55365#1266392, @bapt wrote:

I may be missing some idea on what to test

Might be add some tests for e.g. ru_RU.UTF-8? What do you need for this?

juste provide me a set of command you would expect to work in ru_RU.UTF-8 and and expected output and I will add it to the test suite.

exa% LANG=ru_RU.UTF-8 ./ed
a
Привет
.
s/ривет/ока/
1p
Пока
a
Строка
.
1      
Пока
/а/p
Строка
1,$p
Пока
Строка
Q

(GNU ed)

emaste added a subscriber: emaste.Feb 19 2026, 2:59 PM

no changes

Harbormaster completed remote builds in B70778: Diff 172243.Feb 19 2026, 3:29 PM

https://reviews.freebsd.org/D55364 now has your tests and they pass

In D55365#1266528, @bapt wrote:

https://reviews.freebsd.org/D55364 now has your tests and they pass

Thank you. Looks good for me, but I am not qualified to review.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 1 2026, 11:30 AM

Closed by commit rG5df6aca10906: ed: add unicode support for the l (list) command (authored by bapt). · Explain Why

This revision was automatically updated to reflect the committed changes.

bapt added a commit: rG5df6aca10906: ed: add unicode support for the l (list) command.

Revision Contents
Changeset List

Path

Size

bin/

ed/

ed.h

2 lines

io.c

70 lines

Diff 172243

View Options

bin/ed/ed.h