Page MenuHomeFreeBSD
Differential D55260

ipfilter: Avoid negative array indicies
ClosedPublic
Actions

Authored by cy on Thu, Feb 12, 4:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 25, 8:36 PM
Unknown Object (File)
Sun, Feb 22, 5:19 AM
Unknown Object (File)
Tue, Feb 17, 10:38 AM
Unknown Object (File)
Sun, Feb 15, 6:15 PM
Unknown Object (File)
Fri, Feb 13, 6:43 AM
Unknown Object (File)
Fri, Feb 13, 3:00 AM
Unknown Object (File)
Thu, Feb 12, 5:47 PM
Unknown Object (File)
Thu, Feb 12, 5:13 PM
View All 10 Files
Subscribers
imp
melifaro
vegeta_tuxpowered.net

Details

Reviewers
emaste
markj
glebius
Commits
rG3fdbd8a07a2d: ipfilter: Avoid negative array indicies
Summary

Array indices must always be posive. We avoid this by making each index
unsigned. This mitigates out-of-bounds reads and writes.

Reported by: Ilja Van Sprundel <ivansprundel@ioactive.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70635
Build 67518: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
netpfil/
ipfilter/
netinet/
4 lines
2 lines
2 lines

Diff 171806

View Options

sys/netpfil/ipfilter/netinet/fil.c

Loading...
View Options

sys/netpfil/ipfilter/netinet/ip_fil.h

Loading...
View Options

sys/netpfil/ipfilter/netinet/ip_state.c

Loading...