Page MenuHomeFreeBSD

install: Expect EINTR while copying
Needs ReviewPublic

Authored by des on Sat, Feb 7, 5:46 PM.
Tags
None
Referenced Files
F144622468: D55168.id171461.diff
Tue, Feb 10, 9:07 AM
F144617294: D55168.diff
Tue, Feb 10, 7:40 AM
F144614241: D55168.diff
Tue, Feb 10, 6:57 AM
F144602638: D55168.id171461.diff
Tue, Feb 10, 3:32 AM
Unknown Object (File)
Sat, Feb 7, 5:56 PM
Subscribers

Details

Summary

Both copy_file_range() and read() / write() in our fallback loop can be
interrupted before copying anything at all, in which case it returns -1
and sets errno to EINTR. If that happens, we should retry, not fail.

While here, drop the size argument from copy() (we always want to copy
the entire file anyway) and add a test case that exercises the metalog
and digest functionality.

MFC after: 1 week
PR: 293028

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70506
Build 67389: arc lint + arc unit