Page MenuHomeFreeBSD
Differential D55107

stand/efi: Allow RELAXED or STRICT boot policies
ClosedPublic
Actions

Authored by imp on Wed, Feb 4, 5:46 PM.
Tags
None
Referenced Files
F146306278: D55107.id171171.diff
Sun, Mar 1, 2:33 PM
Unknown Object (File)
Sat, Feb 28, 9:02 PM
Unknown Object (File)
Sat, Feb 28, 8:20 PM
Unknown Object (File)
Sat, Feb 28, 1:41 PM
Unknown Object (File)
Thu, Feb 19, 6:09 AM
Unknown Object (File)
Fri, Feb 13, 8:18 AM
Unknown Object (File)
Thu, Feb 12, 3:44 AM
Unknown Object (File)
Thu, Feb 12, 2:59 AM
View All 17 Files
Subscribers
bcran
dab

Details

Reviewers
mav
glebius
manu
Commits
rG784150fd2535: stand/efi: Allow RELAXED or STRICT boot policies
Summary

The RELAXED boot policy will automatically search for any root
filesystem (currently zfs only) on any device. STRICT policy only
searches on the boot device.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70414
Build 67297: arc lint + arc unit

Event Timeline

imp created this revision.Wed, Feb 4, 5:46 PM
Herald added a reviewer: manu. · View Herald TranscriptWed, Feb 4, 5:46 PM
Herald added subscribers: dab, bcran. · View Herald Transcript
imp requested review of this revision.Wed, Feb 4, 5:46 PM
Harbormaster completed remote builds in B70404: Diff 171160.Wed, Feb 4, 5:46 PM
imp mentioned this in D55094: loader.efi: try all ZFS pools found by efi_zfs_probe().Wed, Feb 4, 5:47 PM
imp updated this revision to Diff 171161.Wed, Feb 4, 6:20 PM

assume the boot dev are first on list.

Harbormaster completed remote builds in B70405: Diff 171161.Wed, Feb 4, 6:20 PM
imp updated this revision to Diff 171162.Wed, Feb 4, 6:27 PM

lookup table for values.

Harbormaster completed remote builds in B70406: Diff 171162.Wed, Feb 4, 6:28 PM
imp updated this revision to Diff 171171.Wed, Feb 4, 7:14 PM

Oh, I don't need the on_bootdev stuff. Simplify.

Harbormaster completed remote builds in B70414: Diff 171171.Wed, Feb 4, 7:14 PM
imp updated this revision to Diff 171172.Wed, Feb 4, 7:15 PM

Oh, don't make silly changes, so we're down to main.c only now.

Harbormaster completed remote builds in B70415: Diff 171172.Wed, Feb 4, 7:15 PM
glebius added inline comments.Wed, Feb 4, 8:13 PM
stand/efi/loader/main.c
151–154

This will make two declarations better coupled together.

611–616

Didn't you you want to skip entries that don't match the condition instead of breaking the cycle? What if next entry is actually the one we want?

glebius added inline comments.Wed, Feb 4, 8:21 PM
stand/efi/loader/main.c
611–616

Now that I've seen your change to D55094, I see that there is no difference between breaking the cycle or skipping entries. So whatever works. But in case if you prefer breaking the cycle, I will suggest to put a comment explaining why we sure that no good entry is there in the list, referencing the other file.

imp added inline comments.Fri, Feb 27, 12:46 AM
stand/efi/loader/main.c
611–616

I think that continue w/o head-insert is better and simpler, so I'll do that. Thanks for the suggestion.

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Feb 27, 1:02 AM
Closed by commit rG784150fd2535: stand/efi: Allow RELAXED or STRICT boot policies (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG784150fd2535: stand/efi: Allow RELAXED or STRICT boot policies.

Revision Contents
Changeset List

PathSize
stand/
efi/
libefi/
3 lines
loader/
40 lines

Diff 171171

View Options

stand/efi/libefi/efizfs.c

Loading...
View Options

stand/efi/loader/main.c

Loading...