diff: Print an error message on I/O error
ClosedPublic
Actions

Authored by des on Feb 4 2026, 6:35 PM.

Details

Reviewers

thj
kevans

Group Reviewers

Klara

Commits

rG07f25fa320af: diff: Print an error message on I/O error
rG55f160fb07ea: diff: Print an error message on I/O error

Summary

If an error occurs while atomizing either file, immediately print an
error message using the error code returned by the atomizer, and set
the error bit in the exit status.

PR: 292198
MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70408
Build 67291: arc lint + arc unit

Event Timeline

des created this revision.Feb 4 2026, 6:35 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 4 2026, 6:35 PM

des requested review of this revision.Feb 4 2026, 6:35 PM

des added a parent revision: D55108: libdiff: Simplify truncation detection.

des added a child revision: D55110: diff: Fix integer overflows in Stone algorithm.

Harbormaster completed remote builds in B70408: Diff 171164.Feb 4 2026, 6:35 PM

thj accepted this revision.Feb 5 2026, 12:54 PM

This revision is now accepted and ready to land.Feb 5 2026, 12:54 PM

kevans accepted this revision.Feb 5 2026, 2:22 PM

Closed by commit rG55f160fb07ea: diff: Print an error message on I/O error (authored by des). · Explain WhyFeb 5 2026, 2:46 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG55f160fb07ea: diff: Print an error message on I/O error.

des added a commit: rG07f25fa320af: diff: Print an error message on I/O error.Feb 10 2026, 3:27 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

diff/

diffreg_new.c

13 lines

Diff 171164

View Options

usr.bin/diff/diffreg_new.c

diff: Print an error message on I/O errorClosedPublicActions