EVENTHANDLER.9: EVENTHANDLER_REGISTER never fails
ClosedPublic
Actions

Authored by obiwac on Jan 31 2026, 4:27 PM.

Details

Reviewers

olce
jhb
zlei

Commits

rGd93f337357a8: EVENTHANDLER.9: EVENTHANDLER_REGISTER never fails
rG9d4bad45e233: EVENTHANDLER.9: EVENTHANDLER_REGISTER never fails

Summary

Since ecdf4409f910 ("Rework the eventhandler locking [...]"),
EVENTHANDLER_REGISTER() can never return NULL.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70291
Build 67174: arc lint + arc unit

Event Timeline

obiwac created this revision.Jan 31 2026, 4:27 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptJan 31 2026, 4:27 PM

obiwac requested review of this revision.Jan 31 2026, 4:27 PM

Harbormaster completed remote builds in B70291: Diff 170859.Jan 31 2026, 4:27 PM

Since ecdf4409f910

Please use a Fixes: trailer for that, it keeps them together for this type of situation is a standardized way. I also have a vague recollection someone built some tooling around it.

LGTM.

In D55014#1257473, @ziaee wrote:

Since ecdf4409f910

Please use a Fixes: trailer for that, it keeps them together for this type of situation is a standardized way. I also have a vague recollection someone built some tooling around it.

+1 for that.

This revision is now accepted and ready to land.Feb 2 2026, 11:44 AM

Would appreciate a:
Suggested by: olce
tag line at commit. Thanks!

Closed by commit rG9d4bad45e233: EVENTHANDLER.9: EVENTHANDLER_REGISTER never fails (authored by obiwac). · Explain WhyFeb 3 2026, 2:59 PM

This revision was automatically updated to reflect the committed changes.

obiwac added a commit: rG9d4bad45e233: EVENTHANDLER.9: EVENTHANDLER_REGISTER never fails.

obiwac added a commit: rGd93f337357a8: EVENTHANDLER.9: EVENTHANDLER_REGISTER never fails.Feb 17 2026, 1:17 PM