Page MenuHomeFreeBSD
Differential D54866

netbsd-tests t_regex_att: Use __nonstring for a non-string constant
ClosedPublic
Actions

Authored by jhb on Jan 25 2026, 4:54 AM.
Tags
None
Referenced Files
F165186415: D54866.id170549.diff
Thu, Aug 6, 2:52 PM
F165146460: D54866.id170363.diff
Thu, Aug 6, 9:48 AM
Unknown Object (File)
Wed, Aug 5, 9:23 AM
Unknown Object (File)
Sat, Aug 1, 9:12 AM
Unknown Object (File)
Mon, Jul 27, 3:22 PM
Unknown Object (File)
Sun, Jul 26, 1:11 PM
Unknown Object (File)
Sat, Jul 25, 4:15 PM
Unknown Object (File)
Wed, Jul 22, 3:47 PM
View All 59 Files
Subscribers
imp
kevans

Details

Reviewers
emaste
dim
ngie
imp
Commits
rG441beb326fbf: netbsd-tests t_regex_att: Use __nonstring for a non-string constant
rG2dea50a661b9: netbsd-tests t_regex_att: Use __nonstring for a non-string constant
Summary

Fixes the following warning from GCC 15:

contrib/netbsd-tests/lib/libc/regex/t_regex_att.c:54:30: error: initializer-string for array of 'char' truncates NUL terminator but destination lacks 'nonstring' attribute (4 chars into 3 available) [-Werror=unterminated-string-initialization]

54 | static const char delim[3] = "\\\\\0";
   |                              ^~~~~~~~

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70121
Build 67004: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 25 2026, 4:54 AM
Herald added a reviewer: ngie. · View Herald TranscriptJan 25 2026, 4:54 AM
Herald added subscribers: kevans, imp. · View Herald Transcript
jhb requested review of this revision.Jan 25 2026, 4:54 AM
jhb added a parent revision: D54865: Merge commit 81b20e110b3f from llvm git (by Roland McGrath):.
jhb added a child revision: D54867: bsd.sys.mk: Silence a few GCC warnings for C++.
Harbormaster completed remote builds in B70121: Diff 170363.Jan 25 2026, 4:55 AM
imp accepted this revision.Jan 25 2026, 10:35 AM
This revision is now accepted and ready to land.Jan 25 2026, 10:35 AM
dim accepted this revision.Jan 25 2026, 12:44 PM

LGTM. Weird that I didn't see this one with clang 21, which also has the same warnings about __nonstring. But maybe I just didn't run this test?

ngie accepted this revision.Jan 25 2026, 7:52 PM

Definitely could be contributed upstream.

jhb added a comment.Jan 27 2026, 6:36 PM

Yeah, I have no idea why clang didn't warn about this one. I wonder if clang doesn't warn if the string ends with an explicit nul?

emaste accepted this revision.Jan 27 2026, 6:39 PM
Closed by commit rG2dea50a661b9: netbsd-tests t_regex_att: Use __nonstring for a non-string constant (authored by jhb). · Explain WhyJan 27 2026, 6:41 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG2dea50a661b9: netbsd-tests t_regex_att: Use __nonstring for a non-string constant.
jhb added a commit: rG441beb326fbf: netbsd-tests t_regex_att: Use __nonstring for a non-string constant.Apr 24 2026, 3:29 PM

Revision Contents
Changeset List

PathSize
contrib/
netbsd-tests/
lib/
libc/
regex/
2 lines

Diff 170363

View Options

contrib/netbsd-tests/lib/libc/regex/t_regex_att.c

Loading...