Page MenuHomeFreeBSD
Differential D54866

netbsd-tests t_regex_att: Use __nonstring for a non-string constant
AcceptedPublic
Actions

Authored by jhb on Sun, Jan 25, 4:54 AM.

Details

Reviewers
emaste
dim
ngie
imp
Summary

Fixes the following warning from GCC 15:

contrib/netbsd-tests/lib/libc/regex/t_regex_att.c:54:30: error: initializer-string for array of 'char' truncates NUL terminator but destination lacks 'nonstring' attribute (4 chars into 3 available) [-Werror=unterminated-string-initialization]

54 | static const char delim[3] = "\\\\\0";
   |                              ^~~~~~~~

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70121
Build 67004: arc lint + arc unit

Event Timeline

jhb created this revision.Sun, Jan 25, 4:54 AM
Herald added a reviewer: ngie. · View Herald TranscriptSun, Jan 25, 4:54 AM
Herald added subscribers: kevans, imp. · View Herald Transcript
jhb requested review of this revision.Sun, Jan 25, 4:54 AM
jhb added a parent revision: D54865: Merge commit 81b20e110b3f from llvm git (by Roland McGrath):.
jhb added a child revision: D54867: bsd.sys.mk: Silence a few GCC warnings for C++.
Harbormaster completed remote builds in B70121: Diff 170363.Sun, Jan 25, 4:55 AM
imp accepted this revision.Sun, Jan 25, 10:35 AM
This revision is now accepted and ready to land.Sun, Jan 25, 10:35 AM
dim accepted this revision.Sun, Jan 25, 12:44 PM

LGTM. Weird that I didn't see this one with clang 21, which also has the same warnings about __nonstring. But maybe I just didn't run this test?

Revision Contents
Changeset List

PathSize
contrib/
netbsd-tests/
lib/
libc/
regex/
2 lines

Diff 170363

View Options

contrib/netbsd-tests/lib/libc/regex/t_regex_att.c

Loading...