Page MenuHomeFreeBSD
Differential D54805

dpaa2: cleanup
ClosedPublic
Actions

Authored by tuexen on Tue, Jan 20, 8:14 PM.
Tags
None
Referenced Files
F142724383: D54805.diff
Thu, Jan 22, 5:30 PM
F142683676: D54805.id170155.diff
Thu, Jan 22, 5:24 AM
F142647656: D54805.id170176.diff
Wed, Jan 21, 8:27 PM
Unknown Object (File)
Wed, Jan 21, 2:43 PM
Unknown Object (File)
Wed, Jan 21, 5:33 AM
Unknown Object (File)
Wed, Jan 21, 1:21 AM
Unknown Object (File)
Wed, Jan 21, 12:11 AM
Unknown Object (File)
Tue, Jan 20, 11:23 PM
View All 10 Files
Subscribers
bz
imp

Details

Reviewers
dsl
timo.voelker_fh-muenster.de
bz
Commits
rGd8b8dc776b7c: dpaa2: cleanup
Summary

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

tuexen created this revision.Tue, Jan 20, 8:14 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, Jan 20, 8:14 PM
tuexen requested review of this revision.Tue, Jan 20, 8:14 PM
bz accepted this revision.Tue, Jan 20, 8:18 PM
bz added a subscriber: bz.

Functionally accepted.

sys/dev/dpaa2/dpaa2_ni.c
2601–2604

Style would say this should be checked against != 0

If we are touching it, we should fix it ;-)

2603

dito

This revision is now accepted and ready to land.Tue, Jan 20, 8:18 PM
bz added a comment.Tue, Jan 20, 8:19 PM

PS: I should really go and read the specs to see if we can steer v4 and v6 independently but my memory says we cannot.

tuexen updated this revision to Diff 170155.Tue, Jan 20, 8:30 PM

Address style comment raised by bz.

This revision now requires review to proceed.Tue, Jan 20, 8:30 PM
tuexen marked 2 inline comments as done.Tue, Jan 20, 8:31 PM
tuexen added inline comments.
sys/dev/dpaa2/dpaa2_ni.c
2601–2604

Both fixed.

tuexen marked an inline comment as done.Tue, Jan 20, 8:31 PM
dsl accepted this revision.Tue, Jan 20, 9:10 PM

lgtm

This revision is now accepted and ready to land.Tue, Jan 20, 9:10 PM
Closed by commit rGd8b8dc776b7c: dpaa2: cleanup (authored by tuexen). · Explain WhyWed, Jan 21, 7:18 AM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rGd8b8dc776b7c: dpaa2: cleanup.
timo.voelker_fh-muenster.de added a comment.Thu, Jan 22, 10:25 AM

Seems to improve the code. Less lines and it looks less complex. This changes the functionality only if IFCAP_RXCSUM and IFCAP_RXCSUM_IPV6 or IFCAP_TXCSUM and IFCAP_TXCSUM_IPV6 get out of sync but, in my understanding of the code, this cannot happen.

Revision Contents
Changeset List

PathSize
sys/
dev/
dpaa2/
24 lines

Diff 170155

View Options

sys/dev/dpaa2/dpaa2_ni.c

Loading...