Page MenuHomeFreeBSD
Differential D54702

virtual_oss: remove needless .include in intermediate Makefile
ClosedPublic
Actions

Authored by brooks on Wed, Jan 14, 12:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 26, 1:22 PM
Unknown Object (File)
Sun, Jan 25, 5:31 AM
Unknown Object (File)
Sat, Jan 24, 5:36 PM
Unknown Object (File)
Sat, Jan 24, 2:05 AM
Unknown Object (File)
Tue, Jan 20, 9:05 PM
Unknown Object (File)
Mon, Jan 19, 4:12 PM
Unknown Object (File)
Mon, Jan 19, 2:42 PM
Unknown Object (File)
Mon, Jan 19, 3:55 AM
View All 14 Files
Subscribers
imp
ivy

Details

Reviewers
christos
emaste
Commits
rG352d405637d2: virtual_oss: remove needless .include in intermediate Makefile
rG497a13601fb7: virtual_oss: remove needless .include in intermediate Makefile
Summary

It doesn't define anything we use.

Sponsored by: DARPA, AFRL

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 69869
Build 66752: arc lint + arc unit

Event Timeline

brooks created this revision.Wed, Jan 14, 12:49 PM
Herald added a subscriber: imp. · View Herald TranscriptWed, Jan 14, 12:49 PM
brooks requested review of this revision.Wed, Jan 14, 12:49 PM
Harbormaster completed remote builds in B69869: Diff 169685.Wed, Jan 14, 12:49 PM
brooks added a child revision: D54703: virtual_oss: build commands/libs in parallel.Wed, Jan 14, 12:50 PM
christos accepted this revision.Wed, Jan 14, 1:37 PM
This revision is now accepted and ready to land.Wed, Jan 14, 1:37 PM
christos added a subscriber: ivy.Wed, Jan 14, 1:41 PM

@ivy Makefile.inc defines:

PACKAGE?=	sound

Is it a problem if the inclusion is removed from here?

brooks added a comment.Wed, Jan 14, 3:01 PM
In D54702#1249777, @christos wrote:

@ivy Makefile.inc defines:

PACKAGE?=	sound

Is it a problem if the inclusion is removed from here?

Why would it be? These Makefiles don't install anything.

ivy added a comment.Thu, Jan 15, 6:18 AM
In D54702#1249777, @christos wrote:

@ivy Makefile.inc defines:

PACKAGE?=	sound

Is it a problem if the inclusion is removed from here?

no, it's fine as long as it's still included by the subdirectories which actually use it, which should happen automatically.

the easiest way to test this is to run make buildworld update-packages, then check <objdir>/worldstage/sound.plist to make sure the things which should be in the sound package are still there.

Closed by commit rG497a13601fb7: virtual_oss: remove needless .include in intermediate Makefile (authored by brooks). · Explain WhyFri, Jan 16, 9:45 AM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rG497a13601fb7: virtual_oss: remove needless .include in intermediate Makefile.
christos added a commit: rG352d405637d2: virtual_oss: remove needless .include in intermediate Makefile.Fri, Jan 30, 4:33 PM

Revision Contents
Changeset List

PathSize
lib/
virtual_oss/
1 line
usr.sbin/
virtual_oss/
1 line

Diff 169685

View Options

lib/virtual_oss/Makefile

Loading...
View Options

usr.sbin/virtual_oss/Makefile

Loading...