lib/virtual_oss: don't (over)link to libsamplerate
Needs ReviewPublic
Actions

Authored by brooks on Wed, Jan 14, 12:50 PM.

Details

Reviewers

christos
emaste

Summary

These plugins require samplerate.h due to virtual_oss's int.h including
it, but don't use any symbols directly so don't link to the library.

Centralize adding the include path.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 69872
Build 66755: arc lint + arc unit

Event Timeline

brooks created this revision.Wed, Jan 14, 12:50 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Jan 14, 12:50 PM

brooks requested review of this revision.Wed, Jan 14, 12:50 PM

Harbormaster completed remote builds in B69872: Diff 169688.Wed, Jan 14, 12:50 PM

brooks added a parent revision: D54704: vitual_oss: build system tidying.Wed, Jan 14, 12:50 PM

The whole stack of review builds including subdirectories that aren't connected to the build (other then sndio since I didn't have libsndio installed). However, these changes are untested and I've only verified this last change by building and examining the library with nm to verity that they don't include surprising undefined symbols.