Page MenuHomeFreeBSD
Differential D54702

virtual_oss: remove needless .include in intermediate Makefile
ClosedPublic
Actions

Authored by brooks on Jan 14 2026, 12:49 PM.
Tags
None
Referenced Files
F146431689: D54702.diff
Mon, Mar 2, 3:49 PM
Unknown Object (File)
Thu, Feb 19, 10:10 PM
Unknown Object (File)
Fri, Feb 13, 6:36 AM
Unknown Object (File)
Sun, Feb 8, 2:49 PM
Unknown Object (File)
Jan 26 2026, 1:22 PM
Unknown Object (File)
Jan 25 2026, 5:31 AM
Unknown Object (File)
Jan 24 2026, 5:36 PM
Unknown Object (File)
Jan 24 2026, 2:05 AM
View All 18 Files
Subscribers
imp
ivy

Details

Reviewers
christos
emaste
Commits
rG352d405637d2: virtual_oss: remove needless .include in intermediate Makefile
rG497a13601fb7: virtual_oss: remove needless .include in intermediate Makefile
Summary

It doesn't define anything we use.

Sponsored by: DARPA, AFRL

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.Jan 14 2026, 12:49 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 14 2026, 12:49 PM
brooks requested review of this revision.Jan 14 2026, 12:49 PM
Harbormaster completed remote builds in B69869: Diff 169685.Jan 14 2026, 12:49 PM
brooks added a child revision: D54703: virtual_oss: build commands/libs in parallel.Jan 14 2026, 12:50 PM
christos accepted this revision.Jan 14 2026, 1:37 PM
This revision is now accepted and ready to land.Jan 14 2026, 1:37 PM
christos added a subscriber: ivy.Jan 14 2026, 1:41 PM

@ivy Makefile.inc defines:

PACKAGE?=	sound

Is it a problem if the inclusion is removed from here?

brooks added a comment.Jan 14 2026, 3:01 PM
In D54702#1249777, @christos wrote:

@ivy Makefile.inc defines:

PACKAGE?=	sound

Is it a problem if the inclusion is removed from here?

Why would it be? These Makefiles don't install anything.

ivy added a comment.Jan 15 2026, 6:18 AM
In D54702#1249777, @christos wrote:

@ivy Makefile.inc defines:

PACKAGE?=	sound

Is it a problem if the inclusion is removed from here?

no, it's fine as long as it's still included by the subdirectories which actually use it, which should happen automatically.

the easiest way to test this is to run make buildworld update-packages, then check <objdir>/worldstage/sound.plist to make sure the things which should be in the sound package are still there.

Closed by commit rG497a13601fb7: virtual_oss: remove needless .include in intermediate Makefile (authored by brooks). · Explain WhyJan 16 2026, 9:45 AM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rG497a13601fb7: virtual_oss: remove needless .include in intermediate Makefile.
christos added a commit: rG352d405637d2: virtual_oss: remove needless .include in intermediate Makefile.Jan 30 2026, 4:33 PM

Revision Contents
Changeset List

PathSize
lib/
virtual_oss/
1 line
usr.sbin/
virtual_oss/
1 line

Diff 169835

View Options

lib/virtual_oss/Makefile

Loading...
View Options

usr.sbin/virtual_oss/Makefile

Loading...