jme: Convert driver to CTLFLAG_MPSAFE
ClosedPublic
Actions

Authored by guest-seuros on Fri, Jan 9, 3:40 PM.

Details

Reviewers

jhb
imp
markj

Commits

rGc2a55efd74cc: jme: Convert driver to CTLFLAG_MPSAFE

Summary

Replace CTLFLAG_NEEDGIANT with CTLFLAG_MPSAFE for all interrupt
coalescing sysctls. The driver uses jme_mtx mutex for proper
synchronization and does not require Giant lock.

Sysctls converted:

dev.jme.X.tx_coal_to (TX coalescing timeout)
dev.jme.X.tx_coal_pkt (TX coalescing packet count)
dev.jme.X.rx_coal_to (RX coalescing timeout)
dev.jme.X.rx_coal_pkt (RX coalescing packet count)
dev.jme.X.process_limit (max RX events to process)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 69781
Build 66664: arc lint + arc unit

Event Timeline

guest-seuros requested review of this revision.Fri, Jan 9, 3:40 PM

guest-seuros created this revision.

Harbormaster completed remote builds in B69754: Diff 169389.Fri, Jan 9, 3:40 PM

speaker, clock: Replace Giant lock with fine-grained locking

Add sx lock to the speaker driver to protect spkr_active and spkr_inbuf,
removing the D_NEEDGIANT flag. Add mtx_lock_spin protection for timer2_state
in clock.c timer_spkr_acquire/release functions.

Harbormaster completed remote builds in B69781: Diff 169445.Sat, Jan 10, 10:32 AM

Sorry, still using arc incorrectly. Need i need to learn git-arc.

markj accepted this revision.Mon, Jan 12, 12:35 AM

This revision is now accepted and ready to land.Mon, Jan 12, 12:35 AM

Closed by commit rGc2a55efd74cc: jme: Convert driver to CTLFLAG_MPSAFE (authored by guest-seuros, committed by markj). · Explain WhyMon, Jan 12, 12:58 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGc2a55efd74cc: jme: Convert driver to CTLFLAG_MPSAFE.