Page MenuHomeFreeBSD

ipfilter: Interface name must not extend beyond end of buffer
Needs ReviewPublic

Authored by cy on Jan 8 2026, 8:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 23, 10:24 AM
Unknown Object (File)
Thu, Feb 12, 8:52 PM
Unknown Object (File)
Sun, Feb 8, 11:20 PM
Unknown Object (File)
Jan 26 2026, 10:59 AM
Unknown Object (File)
Jan 23 2026, 4:53 PM
Unknown Object (File)
Jan 20 2026, 3:21 PM
Unknown Object (File)
Jan 20 2026, 12:01 PM
Unknown Object (File)
Jan 20 2026, 3:17 AM

Details

Summary

sifpidx (an interface name) cannot extend beyond the end of the
fr_names buffer.
We do the validation for fr_sifpidx here because it is a union that
contains an offset only when fr_sifpidx points to an interface name,
an offset into fr_names. The union is an offset into fr_names in this
case only.

Note that sifpidx is only used in ipf_sync() which implments ipf -y.

Reported by: Ilja Van Sprundel <ivansprundel@ioactive.com>
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69737
Build 66620: arc lint + arc unit