Page MenuHomeFreeBSD

ipfilter: Interface name must not extend beyond end of buffer
Needs ReviewPublic

Authored by cy on Jan 8 2026, 8:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 9, 1:59 AM
Unknown Object (File)
Sat, May 30, 12:22 PM
Unknown Object (File)
Sat, May 30, 7:19 AM
Unknown Object (File)
Sat, May 30, 4:13 AM
Unknown Object (File)
Sat, May 30, 4:08 AM
Unknown Object (File)
Fri, May 29, 7:36 PM
Unknown Object (File)
Thu, May 28, 1:39 AM
Unknown Object (File)
Sun, May 17, 4:48 PM

Details

Summary

sifpidx (an interface name) cannot extend beyond the end of the
fr_names buffer.
We do the validation for fr_sifpidx here because it is a union that
contains an offset only when fr_sifpidx points to an interface name,
an offset into fr_names. The union is an offset into fr_names in this
case only.

Note that sifpidx is only used in ipf_sync() which implments ipf -y.

Reported by: Ilja Van Sprundel <ivansprundel@ioactive.com>
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69735
Build 66618: arc lint + arc unit