Page MenuHomeFreeBSD
Differential D54578

zfs: emit .note.GNU-stack section for all ELF targets
ClosedPublic
Actions

Authored by dim on Wed, Jan 7, 5:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 12, 9:55 AM
Unknown Object (File)
Mon, Jan 12, 2:21 AM
Unknown Object (File)
Sat, Jan 10, 4:56 AM
Unknown Object (File)
Fri, Jan 9, 10:13 PM
Unknown Object (File)
Fri, Jan 9, 8:22 PM
Unknown Object (File)
Fri, Jan 9, 6:54 PM
Unknown Object (File)
Fri, Jan 9, 6:54 PM
Unknown Object (File)
Fri, Jan 9, 4:33 PM
View All 14 Files
Subscribers
delphij
imp

Details

Reviewers
emaste
kib
markj
mm
imp
Commits
rGa7d9d1b19608: zfs: emit .note.GNU-stack section for all ELF targets
rG0e80562f15e3: zfs: emit .note.GNU-stack section for all ELF targets
rG74bb8b966381: zfs: emit .note.GNU-stack section for all ELF targets
rGeb1b6ec7a79a: zfs: emit .note.GNU-stack section for all ELF targets
Summary

On FreeBSD, linking the zfs kernel module with binutils ld 2.44 shows
the following warning:

ld: warning: aesni-gcm-avx2-vaes.o: missing .note.GNU-stack section implies executable stack
ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker

Some of the .S files under module/icp/asm-x86_64/modes check whether
to emit the .note.GNU-stack section using:

#if defined(__linux__) && defined(__ELF__)

We could add && defined(__FreeBSD__) to the test, but since all other
.S files in the OpenZFS tree use:

#ifdef __ELF__

it would seem more logical to use that instead. Any recent ELF platform
should support these note sections by now.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 69685
Build 66568: arc lint + arc unit

Event Timeline

dim created this revision.Wed, Jan 7, 5:13 PM
Herald added subscribers: delphij, imp. · View Herald TranscriptWed, Jan 7, 5:13 PM
dim requested review of this revision.Wed, Jan 7, 5:13 PM
Harbormaster completed remote builds in B69685: Diff 169251.Wed, Jan 7, 5:13 PM
dim added a comment.Wed, Jan 7, 5:14 PM

N.B. upstream PR: https://github.com/openzfs/zfs/pull/18119

emaste accepted this revision.Wed, Jan 7, 5:19 PM

I've had to submit some fixes for this exact same #if defined(__linux__) && defined(__ELF__) elsewhere and we're probably going to have to continue chasing this down in various upstreams. IMO it's fine to commit this locally but we should also submit to OpenZFS and to BoringSSL (if not there already).

This revision is now accepted and ready to land.Wed, Jan 7, 5:19 PM
emaste added a comment.Wed, Jan 7, 5:21 PM

https://git.tukaani.org/?p=xz.git;a=commit;h=865e0a3689a25a7ee8eecae1a34c1775e3aa676e
https://reviews.llvm.org/D129587

imp accepted this revision.Wed, Jan 7, 5:49 PM
kib accepted this revision.Wed, Jan 7, 11:51 PM
Closed by commit rGeb1b6ec7a79a: zfs: emit .note.GNU-stack section for all ELF targets (authored by dim). · Explain WhyThu, Jan 8, 8:52 AM
This revision was automatically updated to reflect the committed changes.
dim added a commit: rGeb1b6ec7a79a: zfs: emit .note.GNU-stack section for all ELF targets.
dim added a commit: rG74bb8b966381: zfs: emit .note.GNU-stack section for all ELF targets.Wed, Jan 14, 12:55 AM
dim added a commit: rG0e80562f15e3: zfs: emit .note.GNU-stack section for all ELF targets.
dim added a commit: rGa7d9d1b19608: zfs: emit .note.GNU-stack section for all ELF targets.

Revision Contents
Changeset List

PathSize
sys/
contrib/
openzfs/
module/
icp/
asm-x86_64/
modes/
2 lines
2 lines
2 lines

Diff 169251

View Options

sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-avx2-vaes.S

Loading...
View Options

sys/contrib/openzfs/module/icp/asm-x86_64/modes/aesni-gcm-x86_64.S

Loading...
View Options

sys/contrib/openzfs/module/icp/asm-x86_64/modes/ghash-x86_64.S

Loading...