bhyve: improve console error reporting on arm64
ClosedPublic
Actions

Authored by novel on Sun, Jan 4, 2:14 PM.

Details

Reviewers

andrew
markj

Group Reviewers

bhyve

Commits

rG9fc7fe642757: bhyve: improve console error reporting on arm64

Summary

Currently, on arm64, if bhyve fails to initialize the console,
it falls into assert(), which does not look particularly pretty
for users.

Replace the assert with proper error handling so bhyve prints
a meaningful error message and exits with status code 4 (error).
That matches the behavior on amd64.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

novel created this revision.Sun, Jan 4, 2:14 PM

Herald added a reviewer: andrew. · View Herald TranscriptSun, Jan 4, 2:14 PM

Herald added a reviewer: bhyve. · View Herald Transcript

Herald added subscribers: bcran, rgrimes, emaste, imp. · View Herald Transcript

novel requested review of this revision.Sun, Jan 4, 2:14 PM

Harbormaster completed remote builds in B69604: Diff 169023.Sun, Jan 4, 2:14 PM

Relatively simple way to trigger this error is to run kldunload nmdm and then run bhyve -c 1 -o bootrom=/usr/local/share/u-boot/u-boot-bhyve-arm64/u-boot.bin -o console=/dev/nmdmFoobarA test.

markj accepted this revision as: markj.Sun, Jan 4, 2:29 PM

This revision is now accepted and ready to land.Sun, Jan 4, 2:29 PM

Closed by commit rG9fc7fe642757: bhyve: improve console error reporting on arm64 (authored by novel). · Explain WhyWed, Jan 7, 5:12 PM

This revision was automatically updated to reflect the committed changes.

novel added a commit: rG9fc7fe642757: bhyve: improve console error reporting on arm64.