Differential D43703
motd: stop prepending "uname -v" output dynamically Authored by michaelo on Feb 1 2024, 6:25 PM. Tags None Referenced Files
Details Make the motd generation completely static with this change. PR: 276763
Diff Detail
Event TimelineComment Actions This one comes from: https://github.com/BastilleBSD/bastille/issues/393 Feel free to add someone you think appropriate to review. Comment Actions I don't have strong options either way. On the one hand, I can appreciate how this would confuse some users when they log in to a jail. On the other hand, I expect some users would miss seeing this information (by default) when they log in. While it may also be confusing, it's reporting accurate information that many would expect, i.e., version information about the running kernel. Brainstorming ideas, what about appending something like this to /var/run/motd? echo "$(hostname) $(uname -smi) running kernel/userland: $(uname -r)/$(freebsd-version -u)" In a 14 jail running on a 15-CURRENT host, the output looks like this. myhostname FreeBSD amd64 GENERIC-NODEBUG running kernel/userland: 15.0-CURRENT/14.0-RC4 Comment Actions Yeah, I am open as well. What I would like to see is consistency: either no information or always correct information. What I don't know whether we should try to add something which is done by sysutils/dynamic_motd already. I also wonder whether both freebsd-version -r/freebsd-version -u can also confuse users. While we could introduce a parameter with none, kernel, userland, both, but then we are back with sysutils/dynamic_motd. Comment Actions Remove MFC since it might violate POLA. How to proceed with this review? I still have the feeling that we shouldn't try |