Page MenuHomeFreeBSD
Differential D54086

lltable: use own lock
ClosedPublic
Actions

Authored by glebius on Dec 5 2025, 4:53 PM.
Tags
None
Referenced Files
F163284634: D54086.id.diff
Tue, Jul 21, 5:51 PM
Unknown Object (File)
Sat, Jul 18, 7:26 AM
Unknown Object (File)
Wed, Jul 15, 11:38 AM
Unknown Object (File)
Wed, Jul 15, 6:57 AM
Unknown Object (File)
Wed, Jul 15, 6:57 AM
Unknown Object (File)
Tue, Jul 7, 4:40 PM
Unknown Object (File)
Sat, Jul 4, 3:43 AM
Unknown Object (File)
Sat, Jul 4, 3:40 AM
View All 63 Files
Subscribers
ae
imp
melifaro
zlei

Details

Reviewers
melifaro
zlei
Group Reviewers
network
Commits
rGb986aa05a84d: lltable: use own lock
Summary

Add struct mtx to struct lltable and stop using IF_AFDATA_LOCK, that
was created for a completely different purpose. No functional change
intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

glebius created this revision.Dec 5 2025, 4:53 PM
Herald added a reviewer: melifaro. · View Herald TranscriptDec 5 2025, 4:53 PM
Herald added subscribers: melifaro, ae, imp. · View Herald Transcript
glebius requested review of this revision.Dec 5 2025, 4:53 PM
Harbormaster completed remote builds in B69073: Diff 167590.Dec 5 2025, 4:53 PM
glebius added a parent revision: D54085: net: split ifnet_arrival_event into two events.Dec 5 2025, 4:53 PM
glebius added a child revision: D54089: net: attach IPv4 and IPv6 stacks to an interface with EVENTHANDLER(9).Dec 5 2025, 5:36 PM
melifaro accepted this revision.Dec 7 2025, 9:58 PM
melifaro added inline comments.
sys/netinet6/nd6.c
1559

Probably worth having WLOCK here (which should be in the old code as well).
We may start running nd6_free() for different LLes from multiple threads, resulting in lltable_unlink_entry() running under read lock

This revision is now accepted and ready to land.Dec 7 2025, 9:58 PM
zlei accepted this revision.Dec 8 2025, 10:11 AM
zlei added a subscriber: zlei.

Looks good to me.

Closed by commit rGb986aa05a84d: lltable: use own lock (authored by glebius). · Explain WhyDec 8 2025, 5:21 PM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rGb986aa05a84d: lltable: use own lock.

Revision Contents
Changeset List

PathSize
sys/
net/
9 lines
50 lines
netinet/
16 lines
4 lines
netinet6/
12 lines
8 lines
25 lines
netlink/
route/
5 lines

Diff 167726

View Options

sys/net/if_llatbl.h

Loading...
View Options

sys/net/if_llatbl.c

Loading...
View Options

sys/netinet/if_ether.c

Loading...
View Options

sys/netinet/in.c

Loading...
View Options

sys/netinet6/in6.c

Loading...
View Options

sys/netinet6/mld6.c

Loading...
View Options

sys/netinet6/nd6.c

Loading...
View Options

sys/netlink/route/neigh.c

Loading...