Page MenuHomeFreeBSD
Differential D53845

kqueue(9): document f_copy
Needs ReviewPublic
Actions

Authored by imp on Thu, Nov 20, 4:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 23, 11:50 AM
Unknown Object (File)
Fri, Nov 21, 12:58 AM
Unknown Object (File)
Thu, Nov 20, 10:58 PM
Unknown Object (File)
Thu, Nov 20, 10:27 PM
Unknown Object (File)
Thu, Nov 20, 9:01 PM
Unknown Object (File)
Thu, Nov 20, 7:46 PM
Subscribers
pauamma_gundo.com
ziaee

Details

Reviewers
kib
Summary

f_copy controls whether and how a knote is inherited by the child
process.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68771
Build 65654: arc lint + arc unit

Event Timeline

imp created this revision.Thu, Nov 20, 4:13 PM
Herald added a subscriber: ziaee. · View Herald TranscriptThu, Nov 20, 4:13 PM
imp requested review of this revision.Thu, Nov 20, 4:13 PM
Harbormaster completed remote builds in B68771: Diff 166858.Thu, Nov 20, 4:13 PM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.Thu, Nov 20, 4:49 PM
pauamma_gundo.com added inline comments.
share/man/man9/kqueue.9
208

Did you mean "knote_triv_copy" here?

kib added inline comments.Thu, Nov 20, 4:58 PM
share/man/man9/kqueue.9
214

I do not understand the second half of this sentence (WRT error), and think that the first half could be reformulated.
I suggest to say it like this, feel free to edit the language:

Filter might set
.Dv f_copy
to
.Fn knote_triv_copy
if there is no additional resource handling required, besides shallow copying of the knote itself.

imp updated this revision to Diff 167031.Mon, Nov 24, 4:22 PM

update per review...
... hope to get feedback on whether I should mention attach/detach here or not.

Harbormaster completed remote builds in B68827: Diff 167031.Mon, Nov 24, 4:22 PM
kib added a comment.Mon, Nov 24, 5:05 PM
In D53845#1231594, @imp wrote:

update per review...
... hope to get feedback on whether I should mention attach/detach here or not.

No, attach/detach are not relevant for copy.

share/man/man9/kqueue.9
200

Why did you dropped the description of the f_copy itself?

imp updated this revision to Diff 167063.Tue, Nov 25, 3:13 AM

Doh! Undrop the actual descirption of f_copy... thanks kib for noticing.

Harbormaster completed remote builds in B68834: Diff 167063.Tue, Nov 25, 3:13 AM
imp updated this revision to Diff 167064.Tue, Nov 25, 3:13 AM

Undrop the description. thanks kib for noticing

Harbormaster completed remote builds in B68835: Diff 167064.Tue, Nov 25, 3:13 AM
imp added inline comments.Tue, Nov 25, 3:15 AM
share/man/man9/kqueue.9
206

Or maybe "the not will not be copied to the child process"
I'm not sure which is better.

208

yea, I typed it rather than cut and paste.

214

Yes. That's likely better. Do I need to mention anything about errors calling the detach function (which I saw from code inspection)?

kib added inline comments.Tue, Nov 25, 8:42 AM
share/man/man9/kqueue.9
206

Now I do not quite like either formulation. The idea is to inform that the copied note is not copied. Might be,
When NULL, the current note is not duplicated in the child process kqueue.

kib added inline comments.Tue, Nov 25, 8:44 AM
share/man/man9/kqueue.9
214

No, there is no need. This is a normal flow for destroying knote, and it does not matter why it happen.

Revision Contents
Changeset List

PathSize
share/
man/
man9/
17 lines

Diff 166858

View Options

share/man/man9/kqueue.9

Loading...