sound: Do not use double pointer in dsp_io_ops()
ClosedPublic
Actions

Authored by christos on Thu, Nov 13, 1:46 PM.

Details

Reviewers

markj
emaste
kib

Commits

rGfa7bc9830766: sound: Do not use double pointer in dsp_io_ops()

Summary

No reason to do so.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68599
Build 65482: arc lint + arc unit

Event Timeline

christos created this revision.Thu, Nov 13, 1:46 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Nov 13, 1:46 PM

christos requested review of this revision.Thu, Nov 13, 1:46 PM

Harbormaster completed remote builds in B68599: Diff 166359.Thu, Nov 13, 1:46 PM

kib accepted this revision.Thu, Nov 13, 1:55 PM

kib added inline comments.

sys/dev/sound/pcm/dsp.c
493	At least by style(9), since you are changing the line anyway.
500	Same there and in most other places testing the bit flags.

This revision is now accepted and ready to land.Thu, Nov 13, 1:55 PM

christos added inline comments.Thu, Nov 13, 1:56 PM

sys/dev/sound/pcm/dsp.c
493	There are many places that we check bits like that. I was thinking of addressing that in a commit that changes this everywhere. No?

kib added inline comments.Thu, Nov 13, 2:27 PM

sys/dev/sound/pcm/dsp.c
493	Up to you.

Closed by commit rGfa7bc9830766: sound: Do not use double pointer in dsp_io_ops() (authored by christos). · Explain WhyThu, Nov 13, 2:37 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGfa7bc9830766: sound: Do not use double pointer in dsp_io_ops().

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

dsp.c

26 lines

Diff 166359

View Options

sound: Do not use double pointer in dsp_io_ops()ClosedPublicActions