setcred(): Fix RACCT resource accounting on credentials change
ClosedPublic
Actions

Authored by olce on Oct 29 2025, 8:53 PM.

Details

Reviewers

kevans
kib

Commits

rG8185ac38a099: setcred(): Fix RACCT resource accounting on credentials change
rG76fb5c23dcca: setcred(): Fix RACCT resource accounting on credentials change
rG2e76660cb71d: setcred(): Fix RACCT resource accounting on credentials change
rG2be5127c4a31: setcred(): Fix RACCT resource accounting on credentials change

Summary

When credentials are changed, we need to adjust the sum of resources
associated to the initial and new process' user IDs (and old and new
login classes and jails, but setcred() does not change them) for them to
stay consistent.

PR: 290352
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68286
Build 65169: arc lint + arc unit

Event Timeline

olce created this revision.Oct 29 2025, 8:53 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 29 2025, 8:53 PM

olce requested review of this revision.Oct 29 2025, 8:53 PM

Harbormaster completed remote builds in B68247: Diff 165360.Oct 29 2025, 8:53 PM

Herald added a subscriber: andrew_tao173.riddles.org.uk. · View Herald TranscriptOct 29 2025, 8:53 PM

Wow, sorry, I forgot to wrap the last block (doing rctl_proc_ucred_changed()) inside a if (error == 0).

Ensure the last block is executed only on no error.

Harbormaster completed remote builds in B68249: Diff 165364.Oct 29 2025, 9:03 PM

On RCTL, guard the call to rctl_proc_ucred_changed() with cred_set instead of relying on error being 0 as this is more error-prone on potential future changes to setcred().

Harbormaster completed remote builds in B68286: Diff 165466.Oct 30 2025, 4:27 PM

olce mentioned this in D53456: kern: Fix credentials leaks on RACCT but no RCTL.Oct 31 2025, 11:11 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 2 2025, 6:18 PM

Closed by commit rG2be5127c4a31: setcred(): Fix RACCT resource accounting on credentials change (authored by olce). · Explain Why

This revision was automatically updated to reflect the committed changes.

olce added a commit: rG2be5127c4a31: setcred(): Fix RACCT resource accounting on credentials change.

olce added a child revision: D53563: kern: RACCT: Keep process credentials alive via references.Nov 3 2025, 6:37 PM

olce added a commit: rG2e76660cb71d: setcred(): Fix RACCT resource accounting on credentials change.Nov 6 2025, 3:39 AM

cperciva added a commit: rG76fb5c23dcca: setcred(): Fix RACCT resource accounting on credentials change.Nov 6 2025, 11:12 PM

olce added a commit: rG8185ac38a099: setcred(): Fix RACCT resource accounting on credentials change.Fri, Dec 19, 9:20 AM