Page MenuHomeFreeBSD
Differential D53342

altq: Clear stats structures in get_class_stats()
ClosedPublic
Actions

Authored by markj on Oct 24 2025, 8:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 14, 8:28 AM
Unknown Object (File)
Thu, May 14, 7:57 AM
Unknown Object (File)
Wed, May 13, 8:19 AM
Unknown Object (File)
Wed, May 13, 8:19 AM
Unknown Object (File)
Tue, Apr 28, 6:10 PM
Unknown Object (File)
Mon, Apr 27, 3:32 PM
Unknown Object (File)
Sat, Apr 25, 10:51 AM
Unknown Object (File)
Tue, Apr 21, 7:42 PM
View All 44 Files
Subscribers
ae
glebius
imp
melifaro

Details

Reviewers
emaste
kp
Commits
rG9769eb9282ea: altq: Clear stats structures in get_class_stats()
rG879808d2e5da: altq: Clear stats structures in get_class_stats()
rG83f74730dba1: altq: Clear stats structures in get_class_stats()
rGff08916e9ac6: altq: Clear stats structures in get_class_stats()
Summary

These structures are copied out to userspace, and it's possible to leak
uninitialized stack bytes since these routines and their callers weren't
careful to clear them first. Add memsets to avoid this.

Reported by: Ilja Van Sprundel <ivansprundel@ioactive.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68105
Build 64988: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
net/
altq/
2 lines
2 lines
2 lines

Diff 165006

View Options

sys/net/altq/altq_cbq.c

Loading...
View Options

sys/net/altq/altq_fairq.c

Loading...
View Options

sys/net/altq/altq_priq.c

Loading...