Page MenuHomeFreeBSD
Differential D53308

ipfilter: Calculate the number of elements in ipf_errors
ClosedPublic
Actions

Authored by cy on Oct 23 2025, 11:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 3, 7:57 AM
Unknown Object (File)
Tue, Sep 1, 7:38 AM
Unknown Object (File)
Sat, Aug 29, 3:08 AM
Unknown Object (File)
Tue, Aug 11, 2:44 PM
Unknown Object (File)
Tue, Aug 11, 1:25 PM
Unknown Object (File)
Tue, Aug 11, 6:17 AM
Unknown Object (File)
Aug 9 2026, 3:42 AM
Unknown Object (File)
Aug 8 2026, 4:47 PM
View All 75 Files
Subscribers
imp

Details

Reviewers
emaste
markj
Commits
rGeb411cd796fe: ipfilter: Calculate the number of elements in ipf_errors
rGe73527950d5d: ipfilter: Calculate the number of elements in ipf_errors
rG7051ddc5c703: ipfilter: Calculate the number of elements in ipf_errors
rGab3c9853285b: ipfilter: Calculate the number of elements in ipf_errors
Summary

It serves no purpose to manually manage the IPF_NUM_ERRORS count.
Calculate it instead.

MFC after: 1 day

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68061
Build 64944: arc lint + arc unit

Event Timeline

cy created this revision.Oct 23 2025, 11:01 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 23 2025, 11:01 PM
cy requested review of this revision.Oct 23 2025, 11:01 PM
Harbormaster completed remote builds in B68061: Diff 164914.Oct 23 2025, 11:01 PM
markj accepted this revision.Oct 24 2025, 12:51 PM
This revision is now accepted and ready to land.Oct 24 2025, 12:51 PM
emaste accepted this revision.Oct 24 2025, 1:28 PM

Or if you wanted you could just use nitems() in find_error instead of IPF_NUM_ERRORS

cy added a comment.Oct 24 2025, 10:36 PM
In D53308#1217827, @emaste wrote:

Or if you wanted you could just use nitems() in find_error instead of IPF_NUM_ERRORS

That would require #include <sys/param.h> in interror.c. We don't need the extra definitions (namespace pollution) from param.h.

Closed by commit rGab3c9853285b: ipfilter: Calculate the number of elements in ipf_errors (authored by cy). · Explain WhyNov 5 2025, 3:34 PM
This revision was automatically updated to reflect the committed changes.
cy added a commit: rGab3c9853285b: ipfilter: Calculate the number of elements in ipf_errors.
cy added a commit: rG7051ddc5c703: ipfilter: Calculate the number of elements in ipf_errors.Nov 14 2025, 4:10 AM
cy added a commit: rGe73527950d5d: ipfilter: Calculate the number of elements in ipf_errors.
cy added a commit: rGeb411cd796fe: ipfilter: Calculate the number of elements in ipf_errors.

Revision Contents
Changeset List

PathSize
sbin/
ipf/
libipf/
4 lines

Diff 164914

View Options

sbin/ipf/libipf/interror.c

Loading...