pwait: Add an option to print remaining processes
ClosedPublic
Actions

Authored by des on Oct 23 2025, 10:29 AM.

Details

Reviewers

bcr
markj

Commits

rGb763c111ad2e: pwait: Add an option to print remaining processes
rGcacba7a15e35: pwait: Add an option to print remaining processes
rG955650f18142: pwait: Add an option to print remaining processes
rG3d73146baeb9: pwait: Add an option to print remaining processes

Summary

On startup, insert all valid PIDs into a tree.
In our main loop, whenever a process terminates, remove its PID from the tree.
On exit, if the -p flag was specified, print the remaining PIDs.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68045
Build 64928: arc lint + arc unit

Event Timeline

des created this revision.Oct 23 2025, 10:29 AM

Herald added subscribers: ziaee, imp. · View Herald TranscriptOct 23 2025, 10:29 AM

des requested review of this revision.Oct 23 2025, 10:29 AM

Harbormaster completed remote builds in B68042: Diff 164866.Oct 23 2025, 10:29 AM

des added a child revision: D53294: rc.subr: Fix slow shutdown issue.Oct 23 2025, 10:29 AM

better tests

Harbormaster completed remote builds in B68045: Diff 164879.Oct 23 2025, 12:07 PM

The man page part looks good to me.

This revision is now accepted and ready to land.Oct 23 2025, 6:39 PM

Rather than using a separate rbtree, can you just make each kevent's udata field point to a structure containing the kevent, the PID, and some state indicating whether the process has already exited?

The tree serves the additional purposes of deduplication (which was previously handled by linear search, making the initialization code quadratic in the numbers of processes watched) and stable ordering.

rebase

This revision now requires review to proceed.Oct 27 2025, 7:31 PM

Harbormaster completed remote builds in B68145: Diff 165160.Oct 27 2025, 7:31 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 28 2025, 11:58 AM

Closed by commit rG3d73146baeb9: pwait: Add an option to print remaining processes (authored by des). · Explain Why

This revision was automatically updated to reflect the committed changes.

des added a commit: rG3d73146baeb9: pwait: Add an option to print remaining processes.

des added a commit: rG955650f18142: pwait: Add an option to print remaining processes.Oct 30 2025, 10:38 AM

des added a commit: rGcacba7a15e35: pwait: Add an option to print remaining processes.

cperciva added a commit: rGb763c111ad2e: pwait: Add an option to print remaining processes.Oct 30 2025, 11:53 PM