cam: Add a number of asserts to catch bad transactions
ClosedPublic
Actions

Authored by imp on Oct 22 2025, 3:28 PM.

Details

Reviewers

ken
mav
jhb

Group Reviewers

cam

Commits

rGb558ebb082ff: cam: Add a number of asserts to catch bad transactions

Summary

Ensure that we're in the right state / priority for each of the states
in the driver. These asserts assured that a prior patch that I committed
to fix a priority leak worked when a drive departed (and bounced back
too!). These have been running in our production since I committed the
change and haven't trigged.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 67995
Build 64878: arc lint + arc unit

Event Timeline

imp created this revision.Oct 22 2025, 3:28 PM

Herald added a reviewer: cam. · View Herald TranscriptOct 22 2025, 3:28 PM

imp requested review of this revision.Oct 22 2025, 3:28 PM

Harbormaster completed remote builds in B67993: Diff 164768.Oct 22 2025, 3:29 PM

imp added reviewers: ken, mav, jhb.Oct 22 2025, 3:30 PM

imp added inline comments.Oct 22 2025, 3:33 PM

sys/cam/ata/ata_da.c
2347	I was torn on this one. Maybe it should be an assert instead. However, over the past couple of years since I pushed the fix for this bug, these messages have not appeared in our fleet (before, we'd see a bunch a week, some subset of which would lead to a badly lost race that panic'd the machine).