Page MenuHomeFreeBSD
Differential D53259

cam: Add a number of asserts to catch bad transactions
ClosedPublic
Actions

Authored by imp on Oct 22 2025, 3:28 PM.
Tags
None
Referenced Files
F162883187: D53259.id.diff
Fri, Jul 17, 11:44 PM
Unknown Object (File)
Fri, Jul 17, 6:35 AM
Unknown Object (File)
Thu, Jul 16, 6:41 PM
Unknown Object (File)
Thu, Jul 16, 10:22 AM
Unknown Object (File)
Wed, Jul 15, 6:50 AM
Unknown Object (File)
Wed, Jul 15, 6:50 AM
Unknown Object (File)
Fri, Jul 3, 8:19 AM
Unknown Object (File)
Fri, Jul 3, 6:16 AM
View All 83 Files
Subscribers
None

Details

Reviewers
ken
mav
jhb
Group Reviewers
cam
Commits
rGb558ebb082ff: cam: Add a number of asserts to catch bad transactions
Summary

Ensure that we're in the right state / priority for each of the states
in the driver. These asserts assured that a prior patch that I committed
to fix a priority leak worked when a drive departed (and bounced back
too!). These have been running in our production since I committed the
change and haven't trigged.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 67993
Build 64876: arc lint + arc unit

Event Timeline

imp created this revision.Oct 22 2025, 3:28 PM
Herald added a reviewer: cam. · View Herald TranscriptOct 22 2025, 3:28 PM
imp requested review of this revision.Oct 22 2025, 3:28 PM
Harbormaster completed remote builds in B67993: Diff 164768.Oct 22 2025, 3:29 PM
imp added reviewers: ken, mav, jhb.Oct 22 2025, 3:30 PM
imp added inline comments.Oct 22 2025, 3:33 PM
sys/cam/ata/ata_da.c
2347

I was torn on this one. Maybe it should be an assert instead.
However, over the past couple of years since I pushed the fix for this bug, these messages have not appeared in our fleet (before, we'd see a bunch a week, some subset of which would lead to a badly lost race that panic'd the machine).

imp updated this revision to Diff 164770.Oct 22 2025, 4:07 PM

add da

Harbormaster completed remote builds in B67995: Diff 164770.Oct 22 2025, 4:07 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 6 2025, 6:56 PM
Closed by commit rGb558ebb082ff: cam: Add a number of asserts to catch bad transactions (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGb558ebb082ff: cam: Add a number of asserts to catch bad transactions.

Revision Contents
Changeset List

PathSize
sys/
cam/
ata/
72 lines

Diff 164768

View Options

sys/cam/ata/ata_da.c

Loading...