Page MenuHomeFreeBSD
Differential D53238

nuageinit: Silence luacheck warnings and fix typos
AcceptedPublic
Actions

Authored by jlduran on Tue, Oct 21, 1:32 PM.
Tags
None
Referenced Files
F134814844: D53238.diff
Tue, Nov 4, 6:45 PM
Unknown Object (File)
Mon, Nov 3, 5:27 PM
Unknown Object (File)
Thu, Oct 30, 2:41 PM
Unknown Object (File)
Tue, Oct 28, 10:24 AM
Unknown Object (File)
Tue, Oct 28, 10:18 AM
Unknown Object (File)
Tue, Oct 28, 10:16 AM
Unknown Object (File)
Tue, Oct 28, 10:16 AM
Unknown Object (File)
Sat, Oct 25, 6:14 PM
View All 20 Files
Subscribers
imp

Details

Reviewers
bapt
dtxdf
kevans
Summary

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 67962
Build 64845: arc lint + arc unit

Event Timeline

jlduran created this revision.Tue, Oct 21, 1:32 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, Oct 21, 1:32 PM
jlduran requested review of this revision.Tue, Oct 21, 1:32 PM
Harbormaster completed remote builds in B67960: Diff 164689.Tue, Oct 21, 1:32 PM
jlduran added a child revision: D53239: nuageinit: Add guards against empty user data.Tue, Oct 21, 1:32 PM
jlduran retitled this revision from nuageinit: Silence luacheck warnings to nuageinit: Silence luacheck warnings and fix typos.Tue, Oct 21, 1:39 PM
jlduran edited the summary of this revision. (Show Details)
jlduran updated this revision to Diff 164691.Tue, Oct 21, 1:39 PM
  • Fix typos
Harbormaster completed remote builds in B67962: Diff 164691.Tue, Oct 21, 1:39 PM
kevans accepted this revision.Tue, Oct 21, 2:16 PM

Seems reasonable to me (from a flua perspective; I defer to bapt for nuageinit in general, of course)

libexec/nuageinit/nuageinit
709–714

We could simplify the whole block like this, fwiw

This revision is now accepted and ready to land.Tue, Oct 21, 2:16 PM
jlduran added inline comments.Tue, Oct 21, 2:21 PM
libexec/nuageinit/nuageinit
709–714

I agree. Let's wait from the nuageinit side, if it times out, I'll update the patch with your suggestion.

bapt accepted this revision.Tue, Oct 21, 3:20 PM

LGTM and I like @kevans proposal.

libexec/nuageinit/nuageinit
709–714

I fully agree that the proposed syntax is better, I wasn't aware one could do that with lua ;)

dtxdf accepted this revision.Tue, Oct 21, 4:30 PM

Revision Contents
Changeset List

PathSize
libexec/
nuageinit/
6 lines
20 lines
tests/
2 lines
2 lines

Diff 164691

View Options

libexec/nuageinit/nuage.lua

Loading...
View Options

libexec/nuageinit/nuageinit

Loading...
View Options

libexec/nuageinit/tests/addfile.lua

Loading...
View Options

libexec/nuageinit/tests/nuageinit.sh

Loading...