Page MenuHomeFreeBSD
Differential D53238

nuageinit: Silence luacheck warnings and fix typos
ClosedPublic
Actions

Authored by jlduran on Oct 21 2025, 1:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 13, 5:17 PM
Unknown Object (File)
Mon, May 11, 4:57 AM
Unknown Object (File)
Mon, May 11, 4:57 AM
Unknown Object (File)
Mon, May 11, 4:57 AM
Unknown Object (File)
Sat, May 9, 2:38 PM
Unknown Object (File)
Sat, May 9, 2:31 PM
Unknown Object (File)
Fri, May 8, 1:54 AM
Unknown Object (File)
Fri, May 1, 3:57 AM
View All 64 Files
Subscribers
imp

Details

Reviewers
bapt
dtxdf
kevans
Commits
rG9eca9724b870: nuageinit: Silence luacheck warnings and fix typos
rGa5adb1ca3526: nuageinit: Silence luacheck warnings and fix typos
rG81af04b08140: nuageinit: Silence luacheck warnings and fix typos
Summary

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jlduran created this revision.Oct 21 2025, 1:32 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 21 2025, 1:32 PM
jlduran requested review of this revision.Oct 21 2025, 1:32 PM
Harbormaster completed remote builds in B67960: Diff 164689.Oct 21 2025, 1:32 PM
jlduran added a child revision: D53239: nuageinit: Add guards against empty user data.Oct 21 2025, 1:32 PM
jlduran retitled this revision from nuageinit: Silence luacheck warnings to nuageinit: Silence luacheck warnings and fix typos.Oct 21 2025, 1:39 PM
jlduran edited the summary of this revision. (Show Details)
jlduran updated this revision to Diff 164691.Oct 21 2025, 1:39 PM
  • Fix typos
Harbormaster completed remote builds in B67962: Diff 164691.Oct 21 2025, 1:39 PM
kevans accepted this revision.Oct 21 2025, 2:16 PM

Seems reasonable to me (from a flua perspective; I defer to bapt for nuageinit in general, of course)

libexec/nuageinit/nuageinit
708–710

We could simplify the whole block like this, fwiw

This revision is now accepted and ready to land.Oct 21 2025, 2:16 PM
jlduran added inline comments.Oct 21 2025, 2:21 PM
libexec/nuageinit/nuageinit
708–710

I agree. Let's wait from the nuageinit side, if it times out, I'll update the patch with your suggestion.

bapt accepted this revision.Oct 21 2025, 3:20 PM

LGTM and I like @kevans proposal.

libexec/nuageinit/nuageinit
708–710

I fully agree that the proposed syntax is better, I wasn't aware one could do that with lua ;)

dtxdf accepted this revision.Oct 21 2025, 4:30 PM
Closed by commit rG81af04b08140: nuageinit: Silence luacheck warnings and fix typos (authored by jlduran). · Explain WhyNov 22 2025, 5:32 PM
This revision was automatically updated to reflect the committed changes.
jlduran marked 2 inline comments as done.
jlduran added a commit: rG81af04b08140: nuageinit: Silence luacheck warnings and fix typos.
jlduran added a commit: rGa5adb1ca3526: nuageinit: Silence luacheck warnings and fix typos.Nov 25 2025, 12:43 AM
jlduran added a commit: rG9eca9724b870: nuageinit: Silence luacheck warnings and fix typos.

Revision Contents
Changeset List

PathSize
libexec/
nuageinit/
6 lines
24 lines
tests/
2 lines
2 lines

Diff 166970

View Options

libexec/nuageinit/nuage.lua

Loading...
View Options

libexec/nuageinit/nuageinit

Loading...
View Options

libexec/nuageinit/tests/addfile.lua

Loading...
View Options

libexec/nuageinit/tests/nuageinit.sh

Loading...