Page MenuHomeFreeBSD
Differential D52896

ice.4: Avoid first person language
ClosedPublic
Actions

Authored by brd on Oct 3 2025, 10:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 22, 12:14 PM
Unknown Object (File)
Sat, Aug 8, 3:30 PM
Unknown Object (File)
Sat, Aug 8, 3:20 PM
Unknown Object (File)
Sat, Aug 8, 3:13 PM
Unknown Object (File)
Sat, Aug 8, 3:13 PM
Unknown Object (File)
Sat, Aug 8, 10:27 AM
Unknown Object (File)
Sat, Aug 8, 6:38 AM
Unknown Object (File)
Fri, Aug 7, 11:21 AM
View All Files
Subscribers
imp
ziaee

Details

Reviewers
bcr
ziaee
Commits
rGd1ee21dc55d7: ice.4: Avoid first person language
rG0ee1546565d7: ice.4: Avoid first person language
rG85531add2844: ice.4: Avoid first person language

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brd created this revision.Oct 3 2025, 10:03 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptOct 3 2025, 10:03 PM
brd requested review of this revision.Oct 3 2025, 10:03 PM
Harbormaster completed remote builds in B67534: Diff 163499.Oct 3 2025, 10:03 PM
brd updated this revision to Diff 163500.Oct 3 2025, 10:07 PM

Bump Dd

Harbormaster completed remote builds in B67535: Diff 163500.Oct 3 2025, 10:07 PM
ziaee accepted this revision.Oct 4 2025, 3:06 AM
ziaee added inline comments.
share/man/man4/ice.4
43

Better is to avoid prose here at all according to the mdoc maintainer and also the lightning talk I gave at BSDcan. https://youtu.be/RthIOXpwwsM

417–418

I think this should actually be "If the
.Va allow_no_fec_modules_in_auto
sysctl is enabled...".

Sysctls are Va according to style.mdoc, because then you can apropos Va=here.is.the.sysctl.

764
This revision is now accepted and ready to land.Oct 4 2025, 3:06 AM
brd updated this revision to Diff 163548.Oct 4 2025, 5:57 PM
brd marked 2 inline comments as done.

Address feedback from ziaee

This revision now requires review to proceed.Oct 4 2025, 5:57 PM
Harbormaster completed remote builds in B67550: Diff 163548.Oct 4 2025, 5:57 PM
brd added a comment.Oct 4 2025, 5:58 PM

@ziaee Thanks for taking the time to review!

share/man/man4/ice.4
43

I am sorry, I am not sure what you mean here? Most driver man pages have this exact text.

brd marked an inline comment as not done.Oct 4 2025, 5:58 PM
ziaee accepted this revision.Oct 4 2025, 8:29 PM

Please commit this so I can rewrite the synopsis. Thanks

This revision is now accepted and ready to land.Oct 4 2025, 8:29 PM
Closed by commit rG85531add2844: ice.4: Avoid first person language (authored by brd). · Explain WhyOct 4 2025, 8:46 PM
This revision was automatically updated to reflect the committed changes.
brd added a commit: rG85531add2844: ice.4: Avoid first person language.
brd added a comment.Oct 4 2025, 8:48 PM

Done, thanks! Probably should look at all the driver man pages if that is the case.

ziaee added a commit: rG0ee1546565d7: ice.4: Avoid first person language.Nov 6 2025, 2:17 PM
cperciva added a commit: rGd1ee21dc55d7: ice.4: Avoid first person language.Nov 7 2025, 5:17 AM

Revision Contents
Changeset List

PathSize
share/
man/
man4/
92 lines

Diff 163564

View Options

share/man/man4/ice.4

Loading...