Paths

Table of Contentst

Differential D52863

lib/libc: add recallocarray()
ClosedPublic
Actions

Authored by fuz on Thu, Oct 2, 4:25 PM.

Tags

None

Referenced Files

	F131516050: D52863.diff
	Wed, Oct 8, 8:23 PM

	Unknown Object (File)
	Sat, Oct 4, 4:53 PM

	Unknown Object (File)
	Fri, Oct 3, 7:29 PM

	Unknown Object (File)
	Fri, Oct 3, 2:10 PM

	Unknown Object (File)
	Fri, Oct 3, 9:46 AM

	Unknown Object (File)
	Fri, Oct 3, 8:11 AM

	Unknown Object (File)
	Fri, Oct 3, 4:30 AM

	Unknown Object (File)
	Thu, Oct 2, 6:48 PM

View All 12 Files

Subscribers

Details

Reviewers

kib
imp

Commits

rG42664610795b: lib/libc: add recallocarray()

Summary

This function from OpenBSD is a hybrid of reallocarray() and calloc().
It reallocates an array, clearing any newly allocated items.

The source is taken from lib/libopenbsd, which now no longer has the
function. It ultimately originates from OpenBSD.

A new version FBSD1.9 is added for this FreeBSD 16.0 symbol.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 67507
Build 64390: arc lint + arc unit

Event Timeline

fuz created this revision.Thu, Oct 2, 4:25 PM

Herald added a subscriber: ziaee. · View Herald TranscriptThu, Oct 2, 4:25 PM

fuz requested review of this revision.Thu, Oct 2, 4:25 PM

fuz added a parent revision: D52854: lib{c,openbsd}: use ckd_mul() for overflow checking in re(c)allocarray.Thu, Oct 2, 4:26 PM

Harbormaster completed remote builds in B67495: Diff 163363.Thu, Oct 2, 4:26 PM

fuz added a child revision: D52864: */*: remove recallocarray() compat shims following import into libc.Thu, Oct 2, 4:27 PM

kib added inline comments.Thu, Oct 2, 11:03 PM

lib/libc/Versions.def
56 ↗	(On Diff #163363)	This line should be fixed. Please commit the version addition separately, for MFC.

fuz mentioned this in D52878: lib/libc: add FBSD-1.9 to Versions.def.Fri, Oct 3, 1:50 AM

fuz added a parent revision: D52878: lib/libc: add FBSD-1.9 to Versions.def.Fri, Oct 3, 1:51 AM

move lib/libc/Versions.def change to D52878

Harbormaster completed remote builds in B67507: Diff 163406.Fri, Oct 3, 1:53 AM

fuz added inline comments.Fri, Oct 3, 2:16 AM

lib/libc/Versions.def
56 ↗	(On Diff #163363)	Please offer guidance as to which of the revisions shall be MFC'ed and which not. I am not familiar with the procedure when it comes to backporting FreeBSD 16 symbols to FreeBSD 15.

Both changes (Versions.def) and this one can be MFCed, but we normally do the Versions.def change separately because there might be other symbol in FBSD_1.9 that is merged before your recallocarray.

lib/libc/stdlib/recallocarray.c
41	See my note about merging if()s in other review.

This revision is now accepted and ready to land.Fri, Oct 3, 3:05 AM

re-add recallocarray to lib/libopenbsd when bootstrapping (for mandoc)

This revision now requires review to proceed.Fri, Oct 3, 11:14 AM

Harbormaster completed remote builds in B67514: Diff 163426.Fri, Oct 3, 11:14 AM

fuz mentioned this in D52864: */*: remove recallocarray() compat shims following import into libc.Fri, Oct 3, 11:16 AM

kib accepted this revision.Fri, Oct 3, 5:35 PM

This revision is now accepted and ready to land.Fri, Oct 3, 5:35 PM

Closed by commit rG42664610795b: lib/libc: add recallocarray() (authored by fuz). · Explain WhyFri, Oct 3, 5:48 PM

This revision was automatically updated to reflect the committed changes.

fuz mentioned this in rG969c1191957a: lib/libc: add FBSD-1.9 to Versions.def.

fuz added a commit: rG42664610795b: lib/libc: add recallocarray().

Revision Contents
Changeset List

Path

Size

include/

2 lines

lib/

libc/

stdlib/

3 lines

4 lines

37 lines

	libc/	stdlib/
		libopenbsd/

recallocarray.c

73 lines

libopenbsd/

3 lines

recallocarray.c

Diff 163406

include/stdlib.h

Loading...

lib/libc/stdlib/Makefile.inc

Loading...

lib/libc/stdlib/Symbol.map

Loading...

lib/libc/stdlib/reallocarray.3

Loading...

lib/libc/stdlib/recallocarray.c

Loading...

lib/libopenbsd/Makefile

Loading...

lib/libopenbsd/recallocarray.c

Loading...