Differential D52597

packages: Remove the tests-dev package
ClosedPublic
Actions

Authored by ivy on Wed, Sep 17, 6:56 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 10, 4:04 AM

	Unknown Object (File)
	Thu, Oct 9, 10:50 PM

	Unknown Object (File)
	Thu, Oct 9, 10:50 PM

	Unknown Object (File)
	Thu, Oct 9, 10:50 PM

	Unknown Object (File)
	Thu, Oct 9, 7:19 PM

	Unknown Object (File)
	Sat, Oct 4, 5:55 PM

	Unknown Object (File)
	Sat, Oct 4, 1:49 PM

	Unknown Object (File)
	Sat, Oct 4, 10:23 AM

View All 23 Files

Subscribers

Details

Reviewers

emaste
bapt

Group Reviewers

Commits

rG22ae80be5506: packages: Remove the tests-dev package
rG9065390ddc7b: packages: Remove the tests-dev package

Summary

We don't want a tests-dev package, because this means set-devel depends
on tests-dev, which transitively depends on tests, which means you can't
install set-devel without also getting tests.

The only real "dev" files in tests-dev are from ATF (libprivateatf),
so move that to its own package and add a dependency from tests.

The remaining "dev" files in tests are actually test artifacts, not real
development libraries. Add a new NO_DEV_PACKAGE option to bsd.lib.mk,
which causes dev files to be installed in the base package instead of
creating a -dev package, and set this option for everything that
installs test libraries.

While here, add a slightly more informative description for the tests
packages.

MFC after: 3 seconds

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 67130
Build 64013: arc lint + arc unit

Event Timeline

ivy created this revision.Wed, Sep 17, 6:56 PM

Herald added subscribers: jrtc27, bdragon, emaste and 2 others. · View Herald TranscriptWed, Sep 17, 6:56 PM

Harbormaster completed remote builds in B67130: Diff 162274.Wed, Sep 17, 6:56 PM

ivy requested review of this revision.Wed, Sep 17, 6:56 PM

ivy mentioned this in D52558: bsdinstall: Use package sets for pkgbase install.Wed, Sep 17, 6:59 PM

per IRC discussion, also move kyua to its own package, and add a depdendency from -tests to -set-base

Harbormaster completed remote builds in B67131: Diff 162285.Wed, Sep 17, 8:00 PM

emaste accepted this revision as: emaste.Wed, Sep 17, 8:03 PM

This revision is now accepted and ready to land.Wed, Sep 17, 8:03 PM

bapt accepted this revision.Thu, Sep 18, 6:44 AM

Closed by commit rG9065390ddc7b: packages: Remove the tests-dev package (authored by ivy). · Explain WhyThu, Sep 18, 9:26 AM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rG9065390ddc7b: packages: Remove the tests-dev package.

ivy added a commit: rG22ae80be5506: packages: Remove the tests-dev package.Fri, Sep 19, 1:28 AM

Revision Contents
Changeset List

Path

Size

lib/

atf/

2 lines

libatf-c++/

1 line

tests/

2 lines

libatf-c/

1 line

tests/

2 lines

libc/

tests/

tls/

dso/

1 line

tls_dso/

1 line

libxo/

tests/

encoder/

1 line

libexec/

atf/

2 lines

atf-check/

1 line

atf-pytest-wrapper/

1 line

atf-sh/

1 line

rtld-elf/

tests/

1 line

release/

packages/

ucl/

8 lines

14 lines

share/

mk/

11 lines

3 lines

Diff 162274

lib/atf/Makefile.inc

Loading...

lib/atf/libatf-c++/Makefile

Loading...

lib/atf/libatf-c++/tests/Makefile

Loading...

lib/atf/libatf-c/Makefile

Loading...

lib/atf/libatf-c/tests/Makefile

Loading...

lib/libc/tests/tls/dso/Makefile

Loading...

lib/libc/tests/tls_dso/Makefile

Loading...

lib/libxo/tests/encoder/Makefile

Loading...

libexec/atf/Makefile.inc

Loading...

libexec/atf/atf-check/Makefile

Loading...

libexec/atf/atf-pytest-wrapper/Makefile

Loading...

libexec/atf/atf-sh/Makefile

Loading...

libexec/rtld-elf/tests/Makefile.inc

Loading...

release/packages/ucl/atf-all.ucl

Loading...

release/packages/ucl/tests-all.ucl

Loading...

share/mk/bsd.lib.mk

Loading...

share/mk/bsd.test.mk

Loading...