MAC/do: Restore matching the first supplementary group
ClosedPublic
Actions

Authored by olce on Aug 29 2025, 11:03 PM.

Details

Reviewers

Commits

rGdd5c76309ad9: MAC/do: Restore matching the first supplementary group
rGd39756f23fe2: MAC/do: Restore matching the first supplementary group

Summary

As 'cr_gid' was in fact stored in cr_groups[0],
rule_grant_supplementary_groups() would loop only on further elements of
cr_groups[]. Now that cr_groups[0] is not 'cr_gid' anymore, but some
supplementary group, take it into account.

cred: Update some comments after 'cr_gid' is no more cr_groups[0]

Fixes: be1f7435ef218b1d ("kern: start tracking cr_gid outside of cr_groups[]")
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olce created this revision.Aug 29 2025, 11:03 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 29 2025, 11:03 PM

olce requested review of this revision.Aug 29 2025, 11:03 PM

Harbormaster completed remote builds in B66674: Diff 161237.Aug 29 2025, 11:03 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 17 2025, 12:21 PM

Closed by commit rGd39756f23fe2: MAC/do: Restore matching the first supplementary group (authored by olce). · Explain Why

This revision was automatically updated to reflect the committed changes.

olce added a commit: rGd39756f23fe2: MAC/do: Restore matching the first supplementary group.

olce added a commit: rGdd5c76309ad9: MAC/do: Restore matching the first supplementary group.Sep 23 2025, 12:04 PM

Revision Contents
Changeset List

Path

Size

sys/

security/

mac_do/

mac_do.c

2 lines

Diff 162240

View Options

sys/security/mac_do/mac_do.c

MAC/do: Restore matching the first supplementary groupClosedPublicActions