Page MenuHomeFreeBSD

aarch64: Clarify the initial adjustments to sp for kernel exception entry
ClosedPublic

Authored by jhb on Sep 13 2025, 5:05 PM.
Tags
None
Referenced Files
F142845348: D52514.id162140.diff
Sat, Jan 24, 3:06 AM
Unknown Object (File)
Mon, Jan 5, 4:55 PM
Unknown Object (File)
Fri, Dec 26, 3:27 AM
Unknown Object (File)
Dec 10 2025, 11:56 PM
Unknown Object (File)
Dec 10 2025, 11:10 PM
Unknown Object (File)
Dec 10 2025, 11:09 PM
Unknown Object (File)
Dec 6 2025, 4:49 AM
Unknown Object (File)
Dec 4 2025, 12:55 PM
Subscribers

Details

Summary

The first store-pair instruction in save_registers_head decrements the
stack pointer to create room for most of the trapframe (and the
redzone area for nested exceptions). However, the expression was a
bit non-intuitive as it was using an expression without a leading
negative sign to adjust the stack pointer. Rewrite the expression so
that it is more clearly a negative adjustment to the stack pointer.

Suggested by: andrew
Sponsored by: AFRL, DARPA

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 67001
Build 63884: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Sep 13 2025, 5:05 PM
This revision is now accepted and ready to land.Sep 13 2025, 6:34 PM