hdac: Add patch for new Framework 16 inch laptop.
ClosedPublic
Actions

Authored by aokblast on Mon, Sep 8, 11:28 AM.

Details

Reviewers

christos
lwhsu
markj
git_danielschaefer.me
emaste

Commits

rGc4f9b0df3fa7: snd_hda: Add patch for Framework 16 AMD Ryzen AI 300 Series
rG7f81b2519aeb: snd_hda: Add patch for Framework 16 AMD Ryzen AI 300 Series

Summary

The new Framework 16 inch with ALC285 has the same duplication problem
with previous model. Therefore, we apply the new patch to the new
model.

Sponsored by: The FreeBSD Foundation
Sponsored by: Framework Computer Inc

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aokblast created this revision.Mon, Sep 8, 11:28 AM

Herald added a subscriber: imp. · View Herald TranscriptMon, Sep 8, 11:28 AM

aokblast requested review of this revision.Mon, Sep 8, 11:28 AM

Harbormaster completed remote builds in B66884: Diff 161704.Mon, Sep 8, 11:28 AM

aokblast added reviewers: christos, lwhsu, markj.Mon, Sep 8, 11:29 AM

aokblast added a reviewer: git_danielschaefer.me.

Please rename the commit to "snd_hda: Add patch for Framework 16" so that its easier to read and search for.

Also, does the microphone work properly for this model?

sys/dev/sound/pci/hda/hdaa_patches.c
365–369

The wrapping is a bit awkward and I think style(9)'s allowance for an exception to the 80 col width could be warranted here, if you agree.

        } else if ((id == HDA_CODEC_ALC295 && subid == FRAMEWORK_LAPTOP_0005_SUBVENDOR) ||
            (id == HDA_CODEC_ALC285 && subid == FRAMEWORK_LAPTOP_000D_SUBVENDOR)) {             
                                                                                
``

This revision is now accepted and ready to land.Mon, Sep 8, 1:45 PM

snd_hda: Add patch for Framework 16

Maybe include "2nd gen" or "Framework 16 Ryzen AI 300 series"

Any chance there's a doc for this? Sound on a Chromebook i have doesn't work for similar reasons and i don't know where to start down the rabithole

In D52423#1197216, @imp wrote:

Any chance there's a doc for this? Sound on a Chromebook i have doesn't work for similar reasons and i don't know where to start down the rabithole

snd_hda.4 explains what the as and seq options do, but just tweaking only those does not guarantee you will get your sound to work. Sometimes there has to be additional configuration in case the card's registers are either not properly setup or have non-standard configurations, as is the case for many HDA cards, unfortunately...

Maybe include "2nd gen" or "Framework 16 Ryzen AI 300 series"

The latter please. Or better "Framework 16 AMD Ryzen AI 300 Series"

Also, does the microphone work properly for this model?

Framework 16 does not have a built-in headphone jack.
We did not have enough time to try the built-in microphone.

I sat next to Sheng-Yi when he tried it - this works.

Please corp with the comments about indentation and commit message. Also, we need this MFC to stable/15 at least so please add MFC after: 3 days to be in the next 15.0 build.

In D52423#1197210, @emaste wrote:
The wrapping is a bit awkward and I think style(9)'s allowance for an exception to the 80 col width could be warranted here, if you agree.
        } else if ((id == HDA_CODEC_ALC295 && subid == FRAMEWORK_LAPTOP_0005_SUBVENDOR) ||
            (id == HDA_CODEC_ALC285 && subid == FRAMEWORK_LAPTOP_000D_SUBVENDOR)) {             
                                                                                
``

I will adopt the modification from christos since other part in this file follows that style.
Also, I will merge it tomorrow. Thanks you all!

Closed by commit rG7f81b2519aeb: snd_hda: Add patch for Framework 16 AMD Ryzen AI 300 Series (authored by aokblast). · Explain WhyThu, Sep 11, 4:43 PM

This revision was automatically updated to reflect the committed changes.

aokblast added a commit: rG7f81b2519aeb: snd_hda: Add patch for Framework 16 AMD Ryzen AI 300 Series.

aokblast added a commit: rGc4f9b0df3fa7: snd_hda: Add patch for Framework 16 AMD Ryzen AI 300 Series.Tue, Sep 23, 5:20 PM